From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=V9SrlQfH; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) by mail.toke.dk (Postfix) with ESMTPS id D3A13130B762 for ; Wed, 08 Jul 2026 11:50:29 +0200 (CEST) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id E05BA429C4; Wed, 8 Jul 2026 09:50:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C19091F00A3A; Wed, 8 Jul 2026 09:50:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783504226; bh=/BuyvH1dcxTv4VZSu0HO7PZC50NBeOGm81a2slkrjoY=; h=Subject:From:Date:References:In-Reply-To:To:Cc; b=V9SrlQfHOhqF0FHD6ZdW4xNfsEvuwrbzo3VE0itsZ+4Tj1SCQlDaIvBFpxOK/zynQ gXlyMen2zUGcod3/+EuS6zN1jOoRjOJ6NlY1HGzsINLhsa3w0lIvOZRdlAwcmGFwiy HC9Kxke2uvJWFAWH2AcZ0fP+y4MAmy4TWTJiLleGoWMxfCDFIwDvuw7PD1Q+6GONhG 39aIhHPZVQn7F9UPbKFdUme8LMHI9CDErI7pA3BT7oH50yHQkH0p2CYv/KrBP1hkkP gGKlEiJ42XcTyRREbpP3t98C43zCXqomyhR3l2CI634awpJkB/HDTfgSZA8ZqBIl3y vhxbNNPiecaOw== Received: from [10.30.226.235] (localhost [IPv6:::1]) by aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id 5697339263BF; Wed, 8 Jul 2026 09:50:07 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: patchwork-bot+netdevbpf@kernel.org Message-Id: <178350420589.2406324.14854685159827268973.git-patchwork-notify@kernel.org> Date: Wed, 08 Jul 2026 09:50:05 +0000 References: <20260702000758.297407.e5c888d9d99d.cake-overhead-underflow@trailofbits.com> In-Reply-To: <20260702000758.297407.e5c888d9d99d.cake-overhead-underflow@trailofbits.com> To: Samuel Moelius Cc: toke@toke.dk, jhs@mojatatu.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, cake@lists.bufferbloat.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID-Hash: JKBEET5WCZF5SIN4LPPNI2VPTZII6K4S X-Message-ID-Hash: JKBEET5WCZF5SIN4LPPNI2VPTZII6K4S X-MailFrom: patchwork-bot+netdevbpf@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH v3] net/sched: cake: reject overhead values that underflow length List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Thu, 2 Jul 2026 00:07:59 +0000 you wrote: > CAKE accepts signed overhead values and stores them in an s16, but the > adjusted packet length calculation uses unsigned arithmetic. A negative > effective length can therefore wrap to a large value. > > Such configurations make rate accounting depend on integer wraparound > rather than on the packet size userspace intended to model. A static > netlink lower bound is not enough because packets reaching CAKE can be > smaller than any reasonable manual-overhead allowance. > > [...] Here is the summary with links: - [v3] net/sched: cake: reject overhead values that underflow length https://git.kernel.org/netdev/net/c/b7f97cae7ec1 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html