From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=gDU5Phuo; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04:e001:324:0:1991:8:25]) by mail.toke.dk (Postfix) with ESMTPS id 013C2138CC3C for ; Sat, 25 Jul 2026 01:30:41 +0200 (CEST) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 5406A60A85; Fri, 24 Jul 2026 23:30:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09B341F000E9; Fri, 24 Jul 2026 23:30:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784935839; bh=Zpza3zZJFRgQqkzyQZ775uNn6khMStNPVqzg+X+aL1s=; h=Subject:From:Date:References:In-Reply-To:To:Cc; b=gDU5PhuoxYuU5HXU6wlqrB7kSUGwt4D/9WI/H+Hi2UEQ+Da+Kq69IbkIHgwug0Xpk EMaEtIztS1wDQCvORaDyhfIZAm8CD/udxb0BWcycH7MeKlS4dUrAf8AQpCr8MeNQcA DoQqDfmsbrwvlmH8jMgw4leXDtH0D3Lu/QPd6LHdrl90OL2hFKmPFr6GZUf5aGO8UE vwi84re+unl1xXisqIzDmrCEDqIPYf7sJBItPXJFuK8ZM1i6I4N9SklA1yZIYAfJaL DepAAUn6Nip5ecgooBXiRu7nuqINpqvf4zK3n0UgbCm0KDnyb4iJYAQFVux6T6knN0 9yveJ963tpFWg== Received: from [10.30.226.235] (localhost [IPv6:::1]) by aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id 56AD638111D8; Fri, 24 Jul 2026 23:30:07 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: patchwork-bot+netdevbpf@kernel.org Message-Id: <178493580589.3350809.5507808088090892286.git-patchwork-notify@kernel.org> Date: Fri, 24 Jul 2026 23:30:05 +0000 References: <20260720-sch_cake-skip-clearing-tins-v2-1-e6a8b0275c73@tu-berlin.de> In-Reply-To: <20260720-sch_cake-skip-clearing-tins-v2-1-e6a8b0275c73@tu-berlin.de> To: =?utf-8?q?Jonas_K=C3=B6ppeler_=3Cj=2Ekoeppeler=40tu-berlin=2Ede=3E?=@aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org Cc: toke@toke.dk, jhs@mojatatu.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, cake@lists.bufferbloat.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mikepham4321@gmail.com Message-ID-Hash: 57ODWPIMP2OL5T7MSSBPDBALMSDN6KT7 X-Message-ID-Hash: 57ODWPIMP2OL5T7MSSBPDBALMSDN6KT7 X-MailFrom: patchwork-bot+netdevbpf@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net-next v2] net/sched: sch_cake: skip clearing unused tins during rate adjustment List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Mon, 20 Jul 2026 23:14:52 +0200 you wrote: > When cake_configure_rates() is called from the dequeue path with > rate_adjust=true, it only needs to update the rate parameters. The > loop that clears the unused tins is both unnecessary and harmful in > this path: > > - cake_clear_tin() overwrites q->cur_tin and q->cur_flow, which are > actively used by cake_dequeue(), corrupting the dequeue state. > - iterating over the unused tins and their internal queues to purge > packets adds needless overhead to the hot path. > > [...] Here is the summary with links: - [net-next,v2] net/sched: sch_cake: skip clearing unused tins during rate adjustment https://git.kernel.org/netdev/net/c/a3729e0df005 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html