From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b="MZ/H5Qxx"; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) by mail.toke.dk (Postfix) with ESMTPS id 9614914240C3 for ; Tue, 04 Aug 2026 03:50:48 +0200 (CEST) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 5EC0F401F0; Tue, 4 Aug 2026 01:50:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4063C1F000E9; Tue, 4 Aug 2026 01:50:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785808246; bh=lwQHFXQhl3bgwoMRNhjAwGgHTtX1rDKsgWhyZSN2ZAI=; h=Subject:From:Date:References:In-Reply-To:To:Cc; b=MZ/H5QxxLFXSNVJn3ZA5ZIrT3B9GD+eyovhWr2dnQEqguaZa7E9LLJ4ZwSU1CGs1W WSuUKNOTkAtcnrmZIGwOQ5/ZY8vnel+ojnu9tf2Q1DjwJv/5Uou0QU7zl9e86krBi2 Ke0Cd3zj/Pk2jqWaZxPnC4H/pHNXLSqy3rqQzv+RC4yZ0zXKjxsjoHzefHyVR9SL7p GqZCw72fhOw+L7QsGKK5504fveeP14ZjmsbffWfZK8UrkdTyo4rIXfKKLXyBf2VKW4 Ao6HFTSJqY+GD8lBg1BRZ91RlbbXihKOA92+cT95NFRhB5ExmQKl8VcjT5rqxMGBiK RS1kM0gQmhhdA== Received: from [10.30.226.235] (localhost [IPv6:::1]) by aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id 5697E3924467; Tue, 4 Aug 2026 01:50:08 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: patchwork-bot+netdevbpf@kernel.org Message-Id: <178580820690.2913307.15981227334988638380.git-patchwork-notify@kernel.org> Date: Tue, 04 Aug 2026 01:50:06 +0000 References: <20260729191417.45665-1-toke@toke.dk> In-Reply-To: <20260729191417.45665-1-toke@toke.dk> To: =?utf-8?b?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHRva2UuZGs+?=@aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org Cc: jhs@mojatatu.com, jiri@resnulli.us, davem@davemloft.net, zhilinz@nebusec.ai, enjou1224z@gmail.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, cake@lists.bufferbloat.net, netdev@vger.kernel.org Message-ID-Hash: Z5YPONBUPUDGDQVJ76KMISLSEX2J3QON X-Message-ID-Hash: Z5YPONBUPUDGDQVJ76KMISLSEX2J3QON X-MailFrom: patchwork-bot+netdevbpf@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net] net/sched: sch_cake: drop WARN_ON(1) for malformed packets in ACK filter List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Wed, 29 Jul 2026 21:14:16 +0200 you wrote: > The sch_cake ACK filter parses packets to find the TCP header and filter > duplicated ACKs if the flow is backlogged. The parsing code contains a > WARN_ON(1) which can be triggered by a malformed IP header in certain > cases. Depending on the system configuration, this leads either to > either spamming dmesg with warnings, or a panic if panic_on_warn is set. > > The code already correctly skips the offending packet in the branch that > triggers the warning, so the WARN_ON itself doesn't really serve any > purpose. So just drop it altogether to avoid the inconvenient side > effects. > > [...] Here is the summary with links: - [net] net/sched: sch_cake: drop WARN_ON(1) for malformed packets in ACK filter https://git.kernel.org/netdev/net/c/2a33516f9ef5 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html