From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=BbzfmZWT; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) by mail.toke.dk (Postfix) with ESMTPS id 8450E17243A8 for ; Wed, 30 Sep 2026 17:12:50 +0200 (CEST) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 723A340248; Wed, 30 Sep 2026 15:12:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C9451F000FF; Wed, 30 Sep 2026 15:12:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790781167; bh=RvDEi6ityygBQBBR7ccbCoh0xjOCMqbPQDqOFa9LS4s=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=BbzfmZWTDGzNmQSevrMImht7PMQu8fEDeXRTyoS/uvkr7BmibZJ1mqKJ1VWm4CzaE EYgm8P0kiSnhd5BQxE/dGzK9kielLKzHY9LnbpP45v+K9ui0aXT3f4lu8byzlqM5x5 t7rj5tmiuyjJRS4dSiS2TCsS44WlFeKIEbMCo+uAwwNVFhMST9XvafD9Rxilu4P0Wr dyQCqrp9YXZaKB82MSgjrFC0ZJah0hY4jRGkiRViANRiiKjvkgB2uBS1DXKz87k1dG u564OCgLrfe/CHyazhNIGOUarqmmK8bwlTuBUCVASkZuRLl4OaG9yMxYQUvo66qNLF 2U2dPMaMM/5Ug== From: netdev-bot+sashiko@kernel.org To: ndaugoing@gmail.com Cc: toke@toke.dk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, jhs@mojatatu.com, jiri@resnulli.us, cake@lists.bufferbloat.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Wed, 30 Sep 2026 15:12:46 +0000 Message-ID: <179078116605.434549.16229112833347396709@kernel.org> In-Reply-To: <20260927131009.24250-2-ndaugoing@gmail.com> References: <20260927131009.24250-2-ndaugoing@gmail.com> X-sashiko-severity: Medium Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MailFrom: netdev-bot+sashiko@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: JBGYRI3YOVWGYIR3QW7WSTEMD6GDSZ6S X-Message-ID-Hash: JBGYRI3YOVWGYIR3QW7WSTEMD6GDSZ6S X-Mailman-Approved-At: Thu, 01 Oct 2026 09:53:16 +0200 X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net v3 1/2] net/sched: sch_cake: fix shaper stall on segs == 0 in cake_overhead() List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwNCmlzc3VlKHMpIHRvIGNvbnNpZGVyLg0KDQpDcml0aWNhbDogMCDCtyBIaWdo OiAwIMK3IE1lZGl1bTogMSDCtyBMb3c6IDEgKDEpDQoNCklmIHlvdSBiZWxpZXZlIG5vbmUgb2Yg dGhlIGlzc3VlcyBhcmUgbGVnaXRpbWF0ZSwgcGxlYXNlIHJlcGx5IHRvIGVhY2gNCmlzc3VlIG9m IE1lZGl1bSBzZXZlcml0eSBvciBoaWdoZXIgYW5kIGV4cGxhaW4gd2h5IHRoZSBBSSBpcyB3cm9u Zy4NCklmIGFueSBvZiB0aGVtIGFyZSBsZWdpdGltYXRlIGFuZCB5b3UgcGxhbiB0byByZXNwaW4s IHBsZWFzZSBsZXQgcGF0Y2h3b3JrDQprbm93IGJ5IGluY2x1ZGluZyAicHctYm90OiBjciIgYXMg YSBzZXBhcmF0ZSBsaW5lIGF0IHRoZSBlbmQgb2YgeW91ciByZXBseQ0KKG9uZSBzdWNoIHJlcGx5 IHBlciBzZXJpZXMgaXMgZW5vdWdoKS4NCg0KLSBbTWVkaXVtXSBUaGUgY29tbWl0IG1lc3NhZ2Ug Z2V0cyB0aGUgbWVjaGFuaXNtIGFuZCBpbXBhY3Qgb2YgdGhlIHNlZ3MNCiAgPT0gMCBidWcgd3Jv bmcuDQotIFtMb3ddIFRoZSBjb21taXQgbWVzc2FnZSBuZXZlciBzYXlzIGhvdyBhbiBza2Igd2l0 aCBxZGlzY19wa3Rfc2Vncyhza2IpDQogID09IDAgcmVhY2hlcyB0aGUgbXVsdGktc2VnbWVudCBh cml0aG1ldGljIGluIGNha2Vfb3ZlcmhlYWQoKS4NCg0KUHJlLWV4aXN0aW5nIGlzc3VlczoNCi0g W0xvd10gY2FrZV9vdmVyaGVhZCgpIHNheXMgaXRzIGhlYWRlci1sZW5ndGggbG9naWMgaXMgImJv cnJvd2VkIGZyb20NCiAgcWRpc2NfcGt0X2xlbl9zZWdzX2luaXQoKSIsIGJ1dCBpdCBsYWNrcyB0 aGF0IGZ1bmN0aW9uJ3MgY2hlY2tzLg0KDQotLQ0KDQpuZXQvc2NoZWQ6IHNjaF9jYWtlOiBmaXgg c2hhcGVyIHN0YWxsIG9uIHNlZ3MgPT0gMCBpbiBjYWtlX292ZXJoZWFkKCkNCg0KVGhpcyBwYXRj aCBjaGFuZ2VzIHRoZSBzaW5nbGUtc2VnbWVudCBlYXJseSByZXR1cm4gaW4gY2FrZV9vdmVyaGVh ZCgpIGZyb20NCnNlZ3MgPT0gMSB0byBzZWdzIDw9IDEuIFRoZSBnb2FsIGlzIHRvIHN0b3Agc2ti cyB3aXRoIGEgY2FjaGVkIHNlZ21lbnQgY291bnQNCm9mIDAgZnJvbSByZWFjaGluZyB0aGUgbXVs dGktc2VnbWVudCBvdmVyaGVhZCBhcml0aG1ldGljLg0KDQo+IEJlY2F1c2Ugc2VncyBpcyBhbiB1 bnNpZ25lZCAxNi1iaXQgaW50ZWdlciwgKHNlZ3MgLSAxKSB1bmRlcmZsb3dzIHRvDQo+IDY1NTM1 IChhbmQgaXMgcHJvbW90ZWQgdG8gNDI5NDk2NzI5NSBpbiB0aGUgMzItYml0IHVuc2lnbmVkIGFy aXRobWV0aWMNCj4gYWJvdmUpLiBUaGlzIG11bHRpcGxpZXMgdGhlIHBlci1zZWdtZW50IG92ZXJo ZWFkIGJ5IFVJTlQzMl9NQVgsIHNvDQo+IGNha2Vfb3ZlcmhlYWQoKSByZXR1cm5zIGEgbGVuZ3Ro IGNsb3NlIHRvIDQuMjkgR0IuDQoNCltTZXZlcml0eTogTWVkaXVtXQ0KSXMgdGhpcyBkZXNjcmlw dGlvbiBvZiB0aGUgYXJpdGhtZXRpYyBhY2N1cmF0ZT8gc2VncyBpcyBhIHUxNiwgYnV0IGl0IGlz DQpwcm9tb3RlZCB0byBpbnQgYmVmb3JlIHRoZSBzdWJ0cmFjdGlvbiwgc28gc2VncyAtIDEgaXMg LTEgcmF0aGVyIHRoYW4gNjU1MzUuDQoNClRoZSBsYXN0LXNlZ21lbnQgdGVybSBhbHNvIHdyYXBz IHdoZW4gc2VncyA9PSAwOg0KDQogICAgbGFzdF9sZW4gPSBza2ItPmxlbiAtIHNoaW5mby0+Z3Nv X3NpemUgKiAoc2VncyAtIDEpOw0KDQpUaGlzIGdpdmVzIHNrYi0+bGVuICsgZ3NvX3NpemUuIFdy aXRpbmcgRigpIGZvciBjYWtlX2NhbGNfb3ZlcmhlYWQoKSwgdGhlDQpvbGQgcmV0dXJuIHZhbHVl IHJlZHVjZXMgdG86DQoNCiAgICBGKHNrYi0+bGVuICsgZ3NvX3NpemUpIC0gRihnc29fc2l6ZSAr IGhkcl9sZW4pICAgIChtb2QgMl4zMikNCg0KRigpIG5ldmVyIGRlY3JlYXNlcyBhcyBpdHMgYXJn dW1lbnQgZ3Jvd3MuIFNvIHdoZW4gaGRyX2xlbiA8PSBza2ItPmxlbiwNCndvdWxkbid0IHRoZSBv bGQgY29kZSBjaGFyZ2Ugcm91Z2hseSBza2ItPmxlbiAtIGhkcl9sZW4gcmF0aGVyIHRoYW4NCnNv bWV0aGluZyBjbG9zZSB0byA0LjI5IEdCPw0KDQpUaGUgbGFyZ2Ugd3JhcCBzZWVtcyB0byBuZWVk IGhkcl9sZW4gPiBza2ItPmxlbi4gQXQgdGhpcyBTSEEgdGhhdCBsb29rcw0KcG9zc2libGUgb25s eSB3aGVuIHRoZSB0cmFuc3BvcnQgaGVhZGVyIGlzIHVuc2V0LiBJbiB0aGF0IGNhc2UNCnFkaXNj X3BrdF9sZW5fc2Vnc19pbml0KCkgcmV0dXJucyBlYXJseSBhbmQgbGVhdmVzIHBrdF9zZWdzID09 IGdzb19zZWdzOg0KDQpuZXQvY29yZS9kZXYuYzpxZGlzY19wa3RfbGVuX3NlZ3NfaW5pdCgpIHsN CiAgICAuLi4NCglpZiAoIXNrYi0+ZW5jYXBzdWxhdGlvbikgew0KCQlpZiAodW5saWtlbHkoIXNr Yl90cmFuc3BvcnRfaGVhZGVyX3dhc19zZXQoc2tiKSkpDQoJCQlyZXR1cm4gU0tCX05PVF9EUk9Q UEVEX1lFVDsNCiAgICAuLi4NCn0NCg0KY2FrZV9vdmVyaGVhZCgpIHRoZW4gY29tcHV0ZXMgaGRy X2xlbiBmcm9tIHRoZSB1bnNldCB0cmFuc3BvcnQgb2Zmc2V0LA0Kd2hpY2ggaXMgYXJvdW5kIDB4 RkZGRi4gVGhlIG5leHQgcGF0Y2ggaW4gdGhlIHNlcmllcywgIm5ldC9zY2hlZDogc2NoX2Nha2U6 DQp2YWxpZGF0ZSB0cmFuc3BvcnQgaGVhZGVyIG9mZnNldCBpbiBjYWtlX292ZXJoZWFkKCkiLCB0 YXJnZXRzIHRoYXQgc2FtZQ0KY29uZGl0aW9uLg0KDQpUaGUgNC4yOSBHQiBmaWd1cmUgaXMgdXNl ZCB0byBqdXN0aWZ5IENjOiBzdGFibGUuIENvdWxkIHRoZSBjb21taXQgbWVzc2FnZQ0KZGVzY3Jp YmUgdGhlIGFyaXRobWV0aWMgY29ycmVjdGx5IGFuZCBzdGF0ZSB0aGUgY29uZGl0aW9uIG5lZWRl ZCBmb3IgdGhlDQpzdGFsbD8NCg0KPiBDb21taXQgYzVkMzRmNDU4M2VhICgibmV0X3NjaGVkOiBj YWtlOiB1c2UgcWRpc2NfcGt0X3NlZ3MoKSIpIHN3aXRjaGVkDQo+IGNha2UgdG8gcmV0cmlldmUg dGhlIGNhY2hlZCBzZWdtZW50YXRpb24gY291bnQgdmlhIHFkaXNjX3BrdF9zZWdzKHNrYikNCj4g aW5zdGVhZCBvZiBjYWxjdWxhdGluZyBpdCBsb2NhbGx5IGZvciBkb2RneSBHU08gcGFja2V0cy4g SWYgYW4gc2tiIHdpdGgNCj4gc2VncyA9PSAwIHJlYWNoZXMgY2FrZV9vdmVyaGVhZCgpLCBpdCBz a2lwcyB0aGUgc2VncyA9PSAxIGVhcmx5IHJldHVybg0KPiBhbmQgZW50ZXJzIHRoZSBtdWx0aS1z ZWdtZW50IGFyaXRobWV0aWM6DQoNCltTZXZlcml0eTogTG93XQ0KSG93IGRvZXMgYW4gc2tiIHdp dGggcWRpc2NfcGt0X3NlZ3Moc2tiKSA9PSAwIGdldCBoZXJlPyBGb3IgZXZlcnkNClNLQl9HU09f RE9ER1kgc2tiIHRoYXQgaGFzIGEgdHJhbnNwb3J0IGhlYWRlciwgcWRpc2NfcGt0X2xlbl9zZWdz X2luaXQoKQ0KYWxyZWFkeSByZWNvbXB1dGVzIHBrdF9zZWdzLCBhbmQgaXQgZHJvcHMgdGhlIHNr YiB3aGVuIHBheWxvYWQgPD0gMDoNCg0KbmV0L2NvcmUvZGV2LmM6cWRpc2NfcGt0X2xlbl9zZWdz X2luaXQoKSB7DQogICAgLi4uDQoJaWYgKHVubGlrZWx5KHNoaW5mby0+Z3NvX3R5cGUgJiBTS0Jf R1NPX0RPREdZKSkgew0KCQlpbnQgcGF5bG9hZCA9IHNrYi0+bGVuIC0gaGRyX2xlbjsNCg0KCQkv KiBNYWxpY2lvdXMgcGFja2V0LiAqLw0KCQlpZiAocGF5bG9hZCA8PSAwKQ0KCQkJcmV0dXJuIFNL Ql9EUk9QX1JFQVNPTl9TS0JfQkFEX0dTTzsNCgkJZ3NvX3NlZ3MgPSBESVZfUk9VTkRfVVAocGF5 bG9hZCwgc2hpbmZvLT5nc29fc2l6ZSk7DQoJCXNoaW5mby0+Z3NvX3NlZ3MgPSBnc29fc2VnczsN CgkJcWRpc2Nfc2tiX2NiKHNrYiktPnBrdF9zZWdzID0gZ3NvX3NlZ3M7DQoJfQ0KICAgIC4uLg0K fQ0KDQpwa3Rfc2VncyA9PSAwIHNlZW1zIHRvIHN1cnZpdmUgaW4gb25seSB0d28gY2FzZXM6DQoN CiAgLSB0aGUgZWFybHkgcmV0dXJuIGZvciBhIG5vbi1lbmNhcHN1bGF0ZWQgR1NPIHNrYiB3aXRo IG5vIHRyYW5zcG9ydA0KICAgIGhlYWRlciBzZXQNCiAgLSBhIG5vbi1ET0RHWSBHU08gc2tiIHdo b3NlIGdzb19zZWdzIHdhcyBsZWZ0IGF0IDANCg0KVGhlIGluLXRyZWUgdmlydGlvX25ldF9oZHIg cHJvZHVjZXJzIHNldCBET0RHWS4gT24gYWZfcGFja2V0IHRoZXkgYWxzbyBzZXQNCmEgdHJhbnNw b3J0IGhlYWRlci4NCg0KSW4gdGhlIHNlY29uZCBjYXNlLCB3aXRoIGEgdmFsaWQgdHJhbnNwb3J0 IGhlYWRlciwgdGhlIG5ldyBlYXJseSByZXR1cm4NCmNoYXJnZXMgRihxZGlzY19wa3RfbGVuKCkp LCB3aGljaCBpcyBGKHNrYi0+bGVuIC0gaGRyX2xlbikuIFRoYXQgaXMgYWJvdXQNCndoYXQgdGhl IG9sZCB3cmFwcGVkIHBhdGggY2hhcmdlZC4NCg0KQ291bGQgdGhlIGNvbW1pdCBtZXNzYWdlIG5h bWUgdGhlIHByb2R1Y2VyIG9yIHBhdGggdGhhdCBsZWFkcyBoZXJlPyBUaGF0DQp3b3VsZCBsZXQg dGhlIHJlcHJvZHVjZXIgYW5kIHRoZSAidGVucyBvZiBzZWNvbmRzIiBzdGFsbCBiZSBjaGVja2Vk LCBhbmQNCndvdWxkIGhlbHAgc3RhYmxlIG1haW50YWluZXJzIGp1ZGdlIGV4cG9zdXJlLg0KDQo+ IGRpZmYgLS1naXQgYS9uZXQvc2NoZWQvc2NoX2Nha2UuYyBiL25ldC9zY2hlZC9zY2hfY2FrZS5j DQo+IGluZGV4IGRjOTMyNjcwMjllNzAuLmIwZDYwNGE3MDUyYTkgMTAwNjQ0DQo+IC0tLSBhL25l dC9zY2hlZC9zY2hfY2FrZS5jDQo+ICsrKyBiL25ldC9zY2hlZC9zY2hfY2FrZS5jDQo+IEBAIC0x NDIwLDcgKzE0MjAsNyBAQCBzdGF0aWMgdTMyIGNha2Vfb3ZlcmhlYWQoc3RydWN0IGNha2Vfc2No ZWRfZGF0YSAqcSwgY29uc3Qgc3RydWN0IHNrX2J1ZmYgKnNrYikNCj4gIA0KPiAgCVdSSVRFX09O Q0UocS0+YXZnX25ldG9mZiwgY2FrZV9ld21hKHEtPmF2Z19uZXRvZmYsIG9mZiA8PCAxNiwgOCkp Ow0KPiAgDQo+IC0JaWYgKHNlZ3MgPT0gMSkNCj4gKwlpZiAoc2VncyA8PSAxKQ0KPiAgCQlyZXR1 cm4gY2FrZV9jYWxjX292ZXJoZWFkKHEsIGxlbiwgb2ZmKTsNCj4gIA0KPiAgCS8qIGJvcnJvd2Vk IGZyb20gcWRpc2NfcGt0X2xlbl9zZWdzX2luaXQoKSAqLw0KDQpbU2V2ZXJpdHk6IExvd10NClRo aXMgaXMgYSBwcmUtZXhpc3RpbmcgaXNzdWUsIG5vdCBvbmUgaW50cm9kdWNlZCBieSB0aGlzIHBh dGNoLiBUaGUgY29kZQ0KYWZ0ZXIgdGhpcyBjb21tZW50IGluIGNha2Vfb3ZlcmhlYWQoKSBsYWNr cyBzZXZlcmFsIG9mIHRoZSBjaGVja3MgaW4NCnFkaXNjX3BrdF9sZW5fc2Vnc19pbml0KCk6DQoN Cm5ldC9zY2hlZC9zY2hfY2FrZS5jOmNha2Vfb3ZlcmhlYWQoKSB7DQogICAgLi4uDQoJLyogYm9y cm93ZWQgZnJvbSBxZGlzY19wa3RfbGVuX3NlZ3NfaW5pdCgpICovDQoJaWYgKCFza2ItPmVuY2Fw c3VsYXRpb24pDQoJCWhkcl9sZW4gPSBza2JfdHJhbnNwb3J0X29mZnNldChza2IpOw0KCWVsc2UN CgkJaGRyX2xlbiA9IHNrYl9pbm5lcl90cmFuc3BvcnRfb2Zmc2V0KHNrYik7DQogICAgLi4uDQp9 DQoNCkNvbXBhcmVkIHdpdGggcWRpc2NfcGt0X2xlbl9zZWdzX2luaXQoKSwgaXQgaXMgbWlzc2lu ZzoNCg0KICAtIGEgc2tiX3RyYW5zcG9ydF9oZWFkZXJfd2FzX3NldCgpIGd1YXJkDQogIC0gYSBj aGVjayB0aGF0IF9fdGNwX2hkcmxlbih0aCkgPj0gc2l6ZW9mKHN0cnVjdCB0Y3BoZHIpDQogIC0g YSBwc2tiX21heV9wdWxsKCkgb2YgdGhlIGZ1bGwgaGVhZGVyDQoNCkl0IGFsc28gYWRkcyBzaXpl b2Yoc3RydWN0IHVkcGhkcikgZm9yIGV2ZXJ5IG5vbi1UQ1AgR1NPIHR5cGUsIG5vdCBqdXN0DQpT S0JfR1NPX1VEUF9MNC4NCg0KT2YgdGhlc2UsIG9ubHkgdGhlIG1pc3NpbmcgdHJhbnNwb3J0IGhl YWRlciBndWFyZCBjYW4gY2F1c2UgYSBsYXJnZQ0Kb3ZlcmNoYXJnZS4gV2l0aCBhbiB1bnNldCBo ZWFkZXIsIGhkcl9sZW4gaXMgYXJvdW5kIDY0IEtpQiwgYW5kIGVhY2gNCnNlZ21lbnQgaXMgY2hh cmdlZCB0ZW5zIG9mIEtCIHdoZW4gc2VncyA+PSAyLiBUaGUgZm9sbG93LXVwIHBhdGNoDQoibmV0 L3NjaGVkOiBzY2hfY2FrZTogdmFsaWRhdGUgdHJhbnNwb3J0IGhlYWRlciBvZmZzZXQgaW4gY2Fr ZV9vdmVyaGVhZCgpIg0KYWRkcyB0aGF0IGd1YXJkIGFuZCBhIGhkcl9sZW4gPCAwIGNoZWNrLg0K DQpBZnRlciB0aGUgZnVsbCBzZXJpZXMsIGlzIHRoZSByZW1haW5pbmcgZGlmZmVyZW5jZSBmcm9t IHRoZSBjb3JlIGhlbHBlcg0KaW50ZW5kZWQ/IFdoYXQgaXMgbGVmdCBpcyBzbWFsbCBtaXNhY2Nv dW50aW5nOiB0aGUgVENQIGhlYWRlciBsZW5ndGggdGVybSBpcw0KYm91bmRlZCBhdCA2MCBieXRl cywgYW5kIHRoZSBleHRyYSBVRFAgaGVhZGVyIGlzIDggYnl0ZXMuIFRoaXMgY29kZSBkYXRlcw0K YmFjayB0byBhNzI5YjdmMGJkNWIuDQoNCi0tIA0KU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6 Ly9uZXRkZXYtYWkuYm90cy5saW51eC5kZXYvc2FzaGlrby8jL3BhdGNoc2V0LzIwMjYwOTI3MTMx MDA5LjI0MjUwLTEtbmRhdWdvaW5nJTQwZ21haWwuY29tDQo=