From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b="MC8wgXa/"; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) by mail.toke.dk (Postfix) with ESMTPS id 3F56E172A3F1 for ; Thu, 01 Oct 2026 06:26:37 +0200 (CEST) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 0C67F4354A; Thu, 1 Oct 2026 04:26:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CC6D1F00898; Thu, 1 Oct 2026 04:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790828795; bh=UV95aU7paKdEgSXgO/aM9gvLom7AApvSRNV4BUsbQVU=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=MC8wgXa/k3cpKParEU0z+W1jDI7/3zel8MWerEEDTLOSD9osOtv+BS0Y89kwjnzTB zIUfdEhQPI7pfdf66qBIrkKKl6pCGMgr2uvR7MYoOhKDibRKsYVKeAKIMYV09VVeC3 R8pqAuT+Uwv8+uHS0bKSCfblRB1i8YdfXu1cFhAurlDRitx4MmfxT2uBafSCGQzbgD KfUN56dWQSXEKpv8jXHQVCnyDHw/R9rPaplf+xfjHwqb2evElGiFSyy0aCQrqMWeFi bFOZ5owpkxHeQUNR0ZfMy5qTwzs65Mpu0QhtKzhN4tBqpQwjCEFZfQ588wjXDY4HsH CRoEJpdgWrijQ== From: netdev-bot+sashiko@kernel.org To: ndaugoing@gmail.com Cc: toke@toke.dk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, jhs@mojatatu.com, jiri@resnulli.us, cake@lists.bufferbloat.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Thu, 01 Oct 2026 04:26:34 +0000 Message-ID: <179082879490.434549.12719144237659185288@kernel.org> In-Reply-To: <20260928132452.59996-3-ndaugoing@gmail.com> References: <20260928132452.59996-3-ndaugoing@gmail.com> X-sashiko-severity: High Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MailFrom: netdev-bot+sashiko@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: JMFMYSOL4URRVP7CHSBC44KD6KSWUNWT X-Message-ID-Hash: JMFMYSOL4URRVP7CHSBC44KD6KSWUNWT X-Mailman-Approved-At: Thu, 01 Oct 2026 09:53:21 +0200 X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net v4 2/2] net/sched: sch_cake: validate transport header offset in cake_overhead() List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwNCmlzc3VlKHMpIHRvIGNvbnNpZGVyLg0KDQpDcml0aWNhbDogMCDCtyBIaWdo OiAxIMK3IE1lZGl1bTogMCDCtyBMb3c6IDAgKDEpDQoNCklmIHlvdSBiZWxpZXZlIG5vbmUgb2Yg dGhlIGlzc3VlcyBhcmUgbGVnaXRpbWF0ZSwgcGxlYXNlIHJlcGx5IHRvIGVhY2gNCmlzc3VlIG9m IE1lZGl1bSBzZXZlcml0eSBvciBoaWdoZXIgYW5kIGV4cGxhaW4gd2h5IHRoZSBBSSBpcyB3cm9u Zy4NCklmIGFueSBvZiB0aGVtIGFyZSBsZWdpdGltYXRlIGFuZCB5b3UgcGxhbiB0byByZXNwaW4s IHBsZWFzZSBsZXQgcGF0Y2h3b3JrDQprbm93IGJ5IGluY2x1ZGluZyAicHctYm90OiBjciIgYXMg YSBzZXBhcmF0ZSBsaW5lIGF0IHRoZSBlbmQgb2YgeW91ciByZXBseQ0KKG9uZSBzdWNoIHJlcGx5 IHBlciBzZXJpZXMgaXMgZW5vdWdoKS4NCg0KLSBbSGlnaF0gVGhlIHBhdGNoIGlzIGluY29tcGxl dGUuDQoNClByZS1leGlzdGluZyBpc3N1ZXM6DQotIFtMb3ddIFtCYXNlbGluZTogZGlzY2FyZGVk IGFzIHByZS1leGlzdGluZywgbG93XSBUaGlzIHByb2JsZW0gd2Fzbid0DQogIGludHJvZHVjZWQg YnkgdGhpcyBwYXRjaCwgYnV0IHRoZSBjYWtlX292ZXJoZWFkKCkgYmxvY2sgY29tbWVudGVk4oCm DQoNCi0tDQoNCm5ldC9zY2hlZDogc2NoX2Nha2U6IHZhbGlkYXRlIHRyYW5zcG9ydCBoZWFkZXIg b2Zmc2V0IGluIGNha2Vfb3ZlcmhlYWQoKQ0KDQpUaGlzIHBhdGNoIG1ha2VzIGNha2Vfb3Zlcmhl YWQoKSBmYWxsIGJhY2sgdG8gdGhlIHBsYWluDQpjYWtlX2NhbGNfb3ZlcmhlYWQoKSBwYXRoIGlu IHR3byBjYXNlczogd2hlbiB0aGUgdHJhbnNwb3J0IGhlYWRlciB3YXMNCm5ldmVyIHNldCBvbiBh IG5vbi1lbmNhcHN1bGF0ZWQgc2tiLCBhbmQgd2hlbiB0aGUgY29tcHV0ZWQgdHJhbnNwb3J0DQpv ZmZzZXQgaXMgbmVnYXRpdmUuIGhkcl9sZW4gY2hhbmdlcyBmcm9tIHVuc2lnbmVkIGludCB0byBp bnQgc28gdGhlDQpuZWdhdGl2ZSBjYXNlIGNhbiBiZSBkZXRlY3RlZCwgYW5kIGFsbCBmYWxsYmFj ayBwYXRocyBub3cgZ28gdGhyb3VnaCBhDQpzaW5nbGUgZXJyIGxhYmVsLg0KDQo+IGRpZmYgLS1n aXQgYS9uZXQvc2NoZWQvc2NoX2Nha2UuYyBiL25ldC9zY2hlZC9zY2hfY2FrZS5jDQo+IGluZGV4 IGIwZDYwNGE3MDUyYS4uZjhkZWI4MDgzZjE2IDEwMDY0NA0KPiAtLS0gYS9uZXQvc2NoZWQvc2No X2Nha2UuYw0KPiArKysgYi9uZXQvc2NoZWQvc2NoX2Nha2UuYw0KPiBAQCAtMTQxMywyMSArMTQx MywyOCBAQCBzdGF0aWMgdTMyIGNha2VfY2FsY19vdmVyaGVhZChzdHJ1Y3QgY2FrZV9zY2hlZF9k YXRhICpxZCwgdTMyIGxlbiwgdTMyIG9mZikNCj4gIHN0YXRpYyB1MzIgY2FrZV9vdmVyaGVhZChz dHJ1Y3QgY2FrZV9zY2hlZF9kYXRhICpxLCBjb25zdCBzdHJ1Y3Qgc2tfYnVmZiAqc2tiKQ0KPiAg ew0KDQpbIC4uLiBdDQoNCj4gIAkvKiBib3Jyb3dlZCBmcm9tIHFkaXNjX3BrdF9sZW5fc2Vnc19p bml0KCkgKi8NCj4gLQlpZiAoIXNrYi0+ZW5jYXBzdWxhdGlvbikNCj4gKwlpZiAoIXNrYi0+ZW5j YXBzdWxhdGlvbikgew0KPiArCQlpZiAodW5saWtlbHkoIXNrYl90cmFuc3BvcnRfaGVhZGVyX3dh c19zZXQoc2tiKSkpDQo+ICsJCQlnb3RvIGVycjsNCj4gIAkJaGRyX2xlbiA9IHNrYl90cmFuc3Bv cnRfb2Zmc2V0KHNrYik7DQo+IC0JZWxzZQ0KPiArCX0gZWxzZSB7DQo+ICAJCWhkcl9sZW4gPSBz a2JfaW5uZXJfdHJhbnNwb3J0X29mZnNldChza2IpOw0KPiArCX0NCj4gKw0KPiArCWlmICh1bmxp a2VseShoZHJfbGVuIDwgMCkpDQo+ICsJCWdvdG8gZXJyOw0KDQpbU2V2ZXJpdHk6IEhpZ2hdDQpE b2VzIHRoaXMgZnVsbHkgcmVtb3ZlIHRoZSB+NjYgS0IgcGVyLXNlZ21lbnQgY2hhcmdlIHRoZSBj b21taXQgbWVzc2FnZQ0KZGVzY3JpYmVzPyBUd28gcGF0aHMgc3RpbGwgc2VlbSB0byByZWFjaCBp dC4NCg0KRmlyc3QsIHRoZSBlbmNhcHN1bGF0ZWQgYnJhbmNoIGhhcyBubyBjaGVjayBmb3IgdGhl IHVuc2V0IHNlbnRpbmVsLg0KYnBmX3NrYl9uZXRfZ3JvdygpIGlzIHJlYWNoZWQgdGhyb3VnaCBi cGZfc2tiX2FkanVzdF9yb29tKCkgd2l0aA0KQlBGX0ZfQURKX1JPT01fRU5DQVBfTDNfKi4gSXQg Y29waWVzIHRyYW5zcG9ydF9oZWFkZXIgaW50bw0KaW5uZXJfdHJhbnNwb3J0X2hlYWRlciB3aXRo b3V0IGNoZWNraW5nIHdoZXRoZXIgaXQgd2FzIHNldDoNCg0KbmV0L2NvcmUvZmlsdGVyLmM6YnBm X3NrYl9uZXRfZ3JvdygpIHsNCiAgICAuLi4NCgkJaW5uZXJfdHJhbnMgPSBza2ItPnRyYW5zcG9y dF9oZWFkZXI7DQogICAgLi4uDQoJCXNrYi0+aW5uZXJfdHJhbnNwb3J0X2hlYWRlciA9IGlubmVy X3RyYW5zOw0KICAgIC4uLg0KfQ0KDQpJdCBhbHNvIHNldHMgc2tiLT5lbmNhcHN1bGF0aW9uID0g MS4NCg0KcWRpc2NfcGt0X2xlbl9zZWdzX2luaXQoKSBzdG9yZXMgcGt0X3NlZ3MgYmVmb3JlIGl0 cyAhd2FzX3NldCBlYXJseQ0KcmV0dXJuOg0KDQoJcWRpc2Nfc2tiX2NiKHNrYiktPnBrdF9zZWdz ID0gZ3NvX3NlZ3MgPSBzaGluZm8tPmdzb19zZWdzOw0KCS4uLg0KCWlmICghc2tiLT5lbmNhcHN1 bGF0aW9uKSB7DQoJCWlmICh1bmxpa2VseSghc2tiX3RyYW5zcG9ydF9oZWFkZXJfd2FzX3NldChz a2IpKSkNCgkJCXJldHVybiBTS0JfTk9UX0RST1BQRURfWUVUOw0KDQpTbyBhIEdTTyBza2Igd2l0 aCBhbiB1bnNldCB0cmFuc3BvcnQgaGVhZGVyIGtlZXBzIHBrdF9zZWdzID4gMS4gQSB0Yw0KZWdy ZXNzIHByb2dyYW0gaW4gc2NoX2hhbmRsZV9lZ3Jlc3MoKSwgb3IgYWN0X2JwZiBydW4gZnJvbQ0K Y2FrZV9jbGFzc2lmeSgpLCBjYW4gdGhlbiBlbmNhcHN1bGF0ZSB0aGF0IHNrYi4NCg0KY2FrZV9v dmVyaGVhZCgpIHRoZW4gdGFrZXMgdGhlIGVsc2UgYnJhbmNoIGFuZCBjb21wdXRlcw0KaGRyX2xl biA9IDB4RkZGRiAtIChza2ItPmRhdGEgLSBza2ItPmhlYWQpLiBUaGF0IHZhbHVlIGlzIGxhcmdl IGFuZA0KcG9zaXRpdmUsIHNvIHRoZSBoZHJfbGVuIDwgMCB0ZXN0IGRvZXMgbm90IGNhdGNoIGl0 Lg0KDQpTZWNvbmQsIGJvdGggdGhlIFRDUCBhbmQgVURQIGJyYW5jaGVzIGlnbm9yZSBhIE5VTEwg cmV0dXJuIGZyb20NCnNrYl9oZWFkZXJfcG9pbnRlcigpIGFuZCBrZWVwIHRoZSBvZmZzZXQ6DQoN CgkJdGggPSBza2JfaGVhZGVyX3BvaW50ZXIoc2tiLCBoZHJfbGVuLA0KCQkJCQlzaXplb2YoX3Rj cGhkciksICZfdGNwaGRyKTsNCgkJaWYgKGxpa2VseSh0aCkpDQoJCQloZHJfbGVuICs9IF9fdGNw X2hkcmxlbih0aCk7DQoJLi4uDQoJbGVuID0gc2hpbmZvLT5nc29fc2l6ZSArIGhkcl9sZW47DQoN ClRoZSB1bnJlYWRhYmxlIGhkcl9sZW4gZ29lcyBpbnRvIGxlbiwgd2hpY2ggaXMgdGhlbiBtdWx0 aXBsaWVkIGJ5DQooc2VncyAtIDEpLiBJbiBjYWtlX2VucXVldWUoKSB0aGUgcmVzdWx0IGJlY29t ZXMNCmdldF9jb2JhbHRfY2Ioc2tiKS0+YWRqdXN0ZWRfbGVuLiBUaGF0IHB1c2hlcyB0aGUgc2hh cGVyIGNsb2NrIGZhciBhaGVhZCwNCnN0YWxscyBkZXF1ZXVlLCBhbmQgY29ycnVwdHMgbWF4X25l dGxlbi9tYXhfYWRqbGVuLg0KDQpxZGlzY19wa3RfbGVuX3NlZ3NfaW5pdCgpIHJldHVybnMgU0tC X0RST1BfUkVBU09OX1NLQl9CQURfR1NPIHdoZW5ldmVyDQpwc2tiX21heV9wdWxsKCkgb2YgdGhl IHRyYW5zcG9ydCBoZWFkZXIgZmFpbHMsIHdoaWNoIGNvdmVycyBib3RoIGNhc2VzLg0KDQpXb3Vs ZCBhZGRpbmcgZ290byBlcnIgd2hlbiBza2JfaGVhZGVyX3BvaW50ZXIoKSByZXR1cm5zIE5VTEws IG9yIGNoZWNraW5nDQpoZHJfbGVuIGFnYWluc3Qgc2tiLT5sZW4sIGNvdmVyIHRoZSByZW1haW5p bmcgY2FzZXMgb24gdG9wIG9mIHRoZSBuZXcNCmNoZWNrcz8NCg0KPiAgDQo+ICAJLyogKyB0cmFu c3BvcnQgbGF5ZXIgKi8NCj4gIAlpZiAobGlrZWx5KHNoaW5mby0+Z3NvX3R5cGUgJiAoU0tCX0dT T19UQ1BWNCB8DQoNCltTZXZlcml0eTogTG93XQ0KVGhpcyBpcyBhIHByZS1leGlzdGluZyBpc3N1 ZSBhbmQgd2FzIG5vdCBpbnRyb2R1Y2VkIGJ5IHRoaXMgcGF0Y2guIFRoZQ0KYmxvY2sgbGFiZWxs ZWQgImJvcnJvd2VkIGZyb20gcWRpc2NfcGt0X2xlbl9zZWdzX2luaXQoKSIgZGlmZmVycyBmcm9t IGl0cw0Kc291cmNlLg0KDQpJdCBhZGRzIF9fdGNwX2hkcmxlbih0aCkgd2l0aG91dCB0aGUgdGxl biBjaGVjayB0aGF0DQpxZGlzY19wa3RfbGVuX3NlZ3NfaW5pdCgpIGRvZXM6DQoNCgkJdGxlbiA9 IF9fdGNwX2hkcmxlbih0aCk7DQoJCWlmICh0bGVuIDwgc2l6ZW9mKCp0aCkpDQoJCQlyZXR1cm4g U0tCX0RST1BfUkVBU09OX1NLQl9CQURfR1NPOw0KDQpJdCBhbHNvIGFkZHMgc2l6ZW9mKHN0cnVj dCB1ZHBoZHIpIGluIGEgYmFyZSBlbHNlIGZvciBldmVyeSBub24tVENQIEdTTw0KdHlwZToNCg0K CX0gZWxzZSB7DQoJCXN0cnVjdCB1ZHBoZHIgX3VkcGhkcjsNCg0KCQlpZiAoc2tiX2hlYWRlcl9w b2ludGVyKHNrYiwgaGRyX2xlbiwNCgkJCQkgICAgICAgc2l6ZW9mKF91ZHBoZHIpLCAmX3VkcGhk cikpDQoJCQloZHJfbGVuICs9IHNpemVvZihzdHJ1Y3QgdWRwaGRyKTsNCgl9DQoNClRoZSByZWZl cmVuY2Ugb25seSBkb2VzIHRoaXMgZm9yIFNLQl9HU09fVURQX0w0LiBBcyBhIHJlc3VsdCwgU0NU UCwgRVNQDQpvciBHUkUgR1NPIHRyYWZmaWMgaXMgY2hhcmdlZCA4IGV4dHJhIGJ5dGVzIHBlciBz ZWdtZW50LiBBIGdhcmJhZ2UgZG9mZg0KYWZ0ZXIgaGVhZGVyIG1hbmdsaW5nIGNhbiBjYXVzZSBh biBlcnJvciBvZiB1cCB0byBhYm91dCA2MCBieXRlcyBwZXINCnNlZ21lbnQuDQoNClNob3VsZCB0 aGlzIGJsb2NrIGFsc28gYXBwbHkgdGhlIFNLQl9HU09fVURQX0w0IGFuZCB0bGVuIGNoZWNrcyB0 aGF0DQpxZGlzY19wa3RfbGVuX3NlZ3NfaW5pdCgpIHVzZXM/DQoNCi0tIA0KU2FzaGlrbyBBSSBy ZXZpZXcgwrcgaHR0cHM6Ly9uZXRkZXYtYWkuYm90cy5saW51eC5kZXYvc2FzaGlrby8jL3BhdGNo c2V0LzIwMjYwOTI4MTMyNDUyLjU5OTk2LTEtbmRhdWdvaW5nJTQwZ21haWwuY29tDQo=