From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x22c.google.com (mail-lf0-x22c.google.com [IPv6:2a00:1450:4010:c07::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id CF9C43CB38 for ; Fri, 9 Feb 2018 07:58:46 -0500 (EST) Received: by mail-lf0-x22c.google.com with SMTP id t79so11114622lfe.3 for ; Fri, 09 Feb 2018 04:58:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=7oOmK2Gp9BP4essZCzhFbJUAbah2PwhJ/cGlVqW2AmE=; b=gd0aIfQI2k9uLVreeMAl9Xk9YQ7snv9DIBCEJ2TPsUMj/XamWbuAngHVxoPc7jXWP7 HbHSHBV3TNOodPWvXGn8R+2x+/gApaxtTbZjIn/z/3ZWk2IWbHTJT0xg8tNQyI/c2Ztm 8BE0W1Ny2m4YxQA+DMlk5PDziD6VSwMDYzVwucZSWZ7gWwj63zv8Hc7LlW43LmiMqYtQ Hl2TTk/5oWqOQx1DMOkHZ+WiYKFNggz7R9/iDMS1tdZFup5mo0AoS4ZHmLBi9KxHYmZL S04Qp1U+LznsLiF/dOCvIH1amXH+ORdUwZEYieBjNvY1OMQ4tYT+7DG7jE0Q4XHhkxdW lk4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=7oOmK2Gp9BP4essZCzhFbJUAbah2PwhJ/cGlVqW2AmE=; b=B8v2kQstet9BzC7M86KCE0z5mbwrblnoN+jl/iweSw81SaYuqHaTnCOR+AOFiIc1iV 6o1X6oScfRkx/A0gDgaGjSqhRcBtrGwOAfNPVxH52lKH73jrL8hJFz+pqr/pIYzzKYjS Xn285Hy+ghlZr2tOBrenXTtJTV8sAsY3sg8j2IbnFIHdg8JNDS1r+Ggk3fMlF3FjcVbq 3T/ZUKYYed+tfPg4+qdmKZegECmvDSW64H+WdGXciPRsL7BRlcoPs+wCRKlFI3PSer3g 1N86lBH59G3asbgzKR7kgUhSZbru4YxkZjLeDpLjXB3sPSRpIozj9ePandfeQEjb9TrQ BXWw== X-Gm-Message-State: APf1xPDgCTUns6DCwZdx6pm3wgVH2zoALNW/WzZ41Y1o8HEw4v8NueIC +NYtwG6GsI3lzTye96ZEsgk= X-Google-Smtp-Source: AH8x227Y5PwP0nBy03iZfZKpAnTWBYc9aNq7pMOyJUvj+aGZ406Jodg9DZJ8jamqTSWdEZdBsYQD2Q== X-Received: by 10.46.70.17 with SMTP id t17mr1782157lja.27.1518181125574; Fri, 09 Feb 2018 04:58:45 -0800 (PST) Received: from [192.168.239.216] (83-245-233-185-nat-p.elisa-mobile.fi. [83.245.233.185]) by smtp.gmail.com with ESMTPSA id g10sm419004ljg.94.2018.02.09.04.58.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Feb 2018 04:58:44 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) From: Jonathan Morton In-Reply-To: <20180127130542.25817-1-toke@toke.dk> Date: Fri, 9 Feb 2018 14:58:42 +0200 Cc: cake@lists.bufferbloat.net Content-Transfer-Encoding: quoted-printable Message-Id: <195EF758-2260-4D9B-93D8-492D5E1307B2@gmail.com> References: <20171226150816.27668-1-toke@toke.dk> <20180127130542.25817-1-toke@toke.dk> To: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Mailer: Apple Mail (2.3445.5.20) Subject: Re: [Cake] [PATCH v2] Split tin stats to its own structure to decrease size of tc_cake_xstats X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2018 12:58:47 -0000 > On 27 Jan, 2018, at 3:05 pm, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >=20 > This splits out the tin stats from tc_cake_xstats, which seems like = the > least intrusive way of decreasing the size of the stats structure. = This > way, we can send only the statistics corresponding to the actual = number of > allocated tins, rather than having the xstats structure always be = allocated > for the full number of tins. In order for this patch to work, we would need a corresponding patch for = iproute2 so that it can successfully read the new structure - including = correcting for changes in the size field. - Jonathan Morton