From: Jonathan Morton <chromatix99@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: George Amanakis <gamanakis@gmail.com>, cake@lists.bufferbloat.net
Subject: Re: [Cake] progress? dual-src/dsthost unfairness
Date: Thu, 14 Feb 2019 21:07:01 +0200 [thread overview]
Message-ID: <1D9B46D4-3B6D-4B4A-AD5C-A047BEE4B08F@gmail.com> (raw)
In-Reply-To: <87zhqys0eb.fsf@toke.dk>
>> I tried Toke's and Jonathan's suggestion, dropping the
>> sparse_flow_count. Tthe results are the same (fairness).
>> In a hash collision in this patch the host_bulk_flow_count is not updated,
>> does this make sense?
>
> Yeah, think so; it should be updated later when that flow transitions to
> bulk.
>
> Care to resend with a proper commit message + signed-off-by line (or
> open a pull request on github)? I figure we can put it into the github
> repo for a bit more testing before submitting a patch upstream :)
The important thing is that the host_bulk_flow_count values match the actual bulk-status and host-reference properties assigned to each flow queue. When a hash collision occurs, the bulk-status of the affected flow doesn't change but the hosts to which it refers might do. In that case the host_bulk_flow_count values must be decremented on the old hosts and incremented on the new ones *if* the queue is in the bulk set.
- Jonathan Morton
next prev parent reply other threads:[~2019-02-14 19:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 17:33 Kevin Darbyshire-Bryant
2019-02-13 18:31 ` George Amanakis
2019-02-13 18:41 ` Jonathan Morton
2019-02-13 19:26 ` gamanakis
2019-02-13 19:31 ` Jonathan Morton
2019-02-13 19:35 ` gamanakis
2019-02-13 20:55 ` George Amanakis
2019-02-14 11:15 ` Toke Høiland-Jørgensen
2019-02-14 18:02 ` George Amanakis
2019-02-14 18:14 ` Toke Høiland-Jørgensen
2019-02-14 18:45 ` [Cake] Make the dual modes fairer George Amanakis
2019-02-14 19:07 ` Jonathan Morton [this message]
2019-02-14 20:27 ` [Cake] progress? dual-src/dsthost unfairness gamanakis
2019-02-14 21:22 ` [Cake] Make the dual modes fairer George Amanakis
2019-02-14 21:59 ` Toke Høiland-Jørgensen
2019-02-14 19:00 ` [Cake] progress? dual-src/dsthost unfairness Pete Heist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1D9B46D4-3B6D-4B4A-AD5C-A047BEE4B08F@gmail.com \
--to=chromatix99@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=gamanakis@gmail.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox