From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 9CFCA3CB35 for ; Thu, 14 Feb 2019 14:07:18 -0500 (EST) Received: by mail-lf1-x135.google.com with SMTP id n15so5365538lfe.5 for ; Thu, 14 Feb 2019 11:07:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=6fM3MvDdGQi5Kd3eGX6KzIroQf8qg9iKNXakfpYKaG0=; b=PlDihew18Rtg0bQySM8msmjAAZ0AHwARudsrac99aue7jPHidQubWNRvKHvuQzqq8X XwrZbermkkt4FgTcn/x19hjw8RDBJPKHEhjB8SvGPX77opkbfA3+Z7lDjLecN3Ydm84E 58jhgn9v3gKA9So5zOI3QiKPq335s3aTynv7CQbgXl4iLmhqLyoG5sXmCUo+SMbb9PEH KHy3reiXg2ofwSFWyQOojMZfdFu3+2qNCA6kEyZX+/K2qNGJbtE7ze/hVPN8LJE9rCY3 M8Cc3BS3AtGbqFr01afiGGuGEjivMdjVL0RmufuDFzrbCaWG/6qS/v5uyK9jnqZ7Ttjr gTHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=6fM3MvDdGQi5Kd3eGX6KzIroQf8qg9iKNXakfpYKaG0=; b=qICtl96OUo0n327lDmW1eTu3QHpx0w5lmJ0RnrF4DG6nlWFlfMJbjgKWDdEbbnMD+d oEYgQxYrJAZj4r3c2yExNlIPDjYnFJvP3D1bLPzTI8hFydJM9Pa88ucVcvsX7UCzgJqr RdcQWZW9Ply9FA0AdTKjhDCwbE6VVLWoJtYUfGkRY4Ob5L6vIG9Eak3itVwkf1MDBsWv WneG9+9p4KPB1w6uwDDsq4a6XbAmkxbRiE/2H0GWBZVfar5rGC7Fhg2he4GoebVUu+CK 5lJPJBrj9ybiDRRyYzIuxSkttJZ1Xkh6q34VWeF4n7tq6ldP1UwEhAbeHOw0LLG7TnV/ iIFg== X-Gm-Message-State: AHQUAuZ9V1gjhPLmz284M7KEfFSW0O3I28UPrrPFSrlFvEYlcj0zD05Y Y+qOI6e9O8Qvb0WF0sy++gI= X-Google-Smtp-Source: AHgI3IaZBwEw/XjFeECyQDXfibsydAa4LOhzHKsOmXiJKU9NY2D8/mxIuKseSE5h200YJgHkApLTjg== X-Received: by 2002:ac2:5611:: with SMTP id v17mr3270681lfd.134.1550171237206; Thu, 14 Feb 2019 11:07:17 -0800 (PST) Received: from jonathartonsmbp.lan (83-245-234-39-nat-p.elisa-mobile.fi. [83.245.234.39]) by smtp.gmail.com with ESMTPSA id j82sm644408lfe.13.2019.02.14.11.07.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Feb 2019 11:07:16 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) From: Jonathan Morton In-Reply-To: <87zhqys0eb.fsf@toke.dk> Date: Thu, 14 Feb 2019 21:07:01 +0200 Cc: George Amanakis , cake@lists.bufferbloat.net Content-Transfer-Encoding: quoted-printable Message-Id: <1D9B46D4-3B6D-4B4A-AD5C-A047BEE4B08F@gmail.com> References: <87a7iymxie.fsf@toke.dk> <20190214180217.13090-1-gamanakis@gmail.com> <87zhqys0eb.fsf@toke.dk> To: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Mailer: Apple Mail (2.3445.9.1) Subject: Re: [Cake] progress? dual-src/dsthost unfairness X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2019 19:07:18 -0000 >> I tried Toke's and Jonathan's suggestion, dropping the >> sparse_flow_count. Tthe results are the same (fairness). >> In a hash collision in this patch the host_bulk_flow_count is not = updated, >> does this make sense? >=20 > Yeah, think so; it should be updated later when that flow transitions = to > bulk. >=20 > Care to resend with a proper commit message + signed-off-by line (or > open a pull request on github)? I figure we can put it into the github > repo for a bit more testing before submitting a patch upstream :) The important thing is that the host_bulk_flow_count values match the = actual bulk-status and host-reference properties assigned to each flow = queue. When a hash collision occurs, the bulk-status of the affected = flow doesn't change but the hosts to which it refers might do. In that = case the host_bulk_flow_count values must be decremented on the old = hosts and incremented on the new ones *if* the queue is in the bulk set. - Jonathan Morton=