From: Stephen Hemminger <stephen@networkplumber.org>
To: Dave Taht <dave.taht@gmail.com>
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] [PATCH 1/3] pkt_sched.h: add support for sch_cake API
Date: Tue, 21 Nov 2017 16:55:13 -0800 [thread overview]
Message-ID: <20171121165513.036b01da@xeon-e3> (raw)
In-Reply-To: <1511309382-24060-2-git-send-email-dave.taht@gmail.com>
On Tue, 21 Nov 2017 16:09:40 -0800
Dave Taht <dave.taht@gmail.com> wrote:
>
> +/* CAKE */
> +enum {
> + TCA_CAKE_UNSPEC,
> + TCA_CAKE_BASE_RATE,
> + TCA_CAKE_DIFFSERV_MODE,
> + TCA_CAKE_ATM,
> + TCA_CAKE_FLOW_MODE,
> + TCA_CAKE_OVERHEAD,
> + TCA_CAKE_RTT,
> + TCA_CAKE_TARGET,
> + TCA_CAKE_AUTORATE,
> + TCA_CAKE_MEMORY,
> + TCA_CAKE_NAT,
> + TCA_CAKE_ETHERNET,
> + TCA_CAKE_WASH,
> + TCA_CAKE_MPU,
> + TCA_CAKE_INGRESS,
> + TCA_CAKE_ACK_FILTER,
> + __TCA_CAKE_MAX
> +};
> +#define TCA_CAKE_MAX (__TCA_CAKE_MAX - 1)
> +
> +struct tc_cake_traffic_stats {
> + __u32 packets;
> + __u32 link_ms;
> + __u64 bytes;
> +};
> +
> +#define TC_CAKE_MAX_TINS (8)
> +struct tc_cake_xstats {
> + __u16 version; /* == 5, increments when struct extended */
> + __u8 max_tins; /* == TC_CAKE_MAX_TINS */
> + __u8 tin_cnt; /* <= TC_CAKE_MAX_TINS */
> +
> + __u32 threshold_rate[TC_CAKE_MAX_TINS];
> + __u32 target_us[TC_CAKE_MAX_TINS];
> + struct tc_cake_traffic_stats sent[TC_CAKE_MAX_TINS];
> + struct tc_cake_traffic_stats dropped[TC_CAKE_MAX_TINS];
> + struct tc_cake_traffic_stats ecn_marked[TC_CAKE_MAX_TINS];
> + struct tc_cake_traffic_stats backlog[TC_CAKE_MAX_TINS];
> + __u32 interval_us[TC_CAKE_MAX_TINS];
> + __u32 way_indirect_hits[TC_CAKE_MAX_TINS];
> + __u32 way_misses[TC_CAKE_MAX_TINS];
> + __u32 way_collisions[TC_CAKE_MAX_TINS];
> + __u32 peak_delay_us[TC_CAKE_MAX_TINS]; /* ~= bulk flow delay */
> + __u32 avge_delay_us[TC_CAKE_MAX_TINS];
> + __u32 base_delay_us[TC_CAKE_MAX_TINS]; /* ~= sparse flows delay */
> + __u16 sparse_flows[TC_CAKE_MAX_TINS];
> + __u16 bulk_flows[TC_CAKE_MAX_TINS];
> + __u16 unresponse_flows[TC_CAKE_MAX_TINS]; /* v4 - was u32 last_len */
> + __u16 spare[TC_CAKE_MAX_TINS]; /* v4 - split last_len */
> + __u32 max_skblen[TC_CAKE_MAX_TINS];
> + __u32 capacity_estimate; /* version 2 */
> + __u32 memory_limit; /* version 3 */
> + __u32 memory_used; /* version 3 */
> + struct tc_cake_traffic_stats ack_drops[TC_CAKE_MAX_TINS]; /* v5 */
> +};
> +
Rather than passing one big structure (like xstats) through netlink, it is more typical
to break it into separate TLV items.
Also, when I see multiple arrays of same size. It seems the API should
be:
struct tc_cake_tin_stats {
__u32 threshold_rate;
__u32 target_us;
struct tc_cake_traffic_stats sent;
...
What if you want to change number of TINS, the ABI shouldn't have to change.
next prev parent reply other threads:[~2017-11-22 0:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 0:09 [Cake] [PATCH 0/3] Add Common Applications Kept Enhanced (sch_cake) qdisc Dave Taht
2017-11-22 0:09 ` [Cake] [PATCH 1/3] pkt_sched.h: add support for sch_cake API Dave Taht
2017-11-22 0:55 ` Stephen Hemminger [this message]
2017-11-22 0:58 ` Dave Taht
2017-11-22 21:38 ` Stephen Hemminger
2017-11-22 22:35 ` Dave Taht
2017-11-24 13:33 ` Marcelo Ricardo Leitner
2017-11-24 20:53 ` Dave Taht
[not found] ` <CAJq5cE2j9o1vHhxEecHkKMUv65d-BxDvXNJXPWh=WHmXVqNUQA@mail.gmail.com>
[not found] ` <CAJq5cE36nijxKM6dpRPK2d8axZwf=35a8D=2oArPjusRKALLpA@mail.gmail.com>
2017-11-22 6:59 ` Jonathan Morton
2017-11-22 0:09 ` [Cake] [PATCH 2/3] Add Common Applications Kept Enhanced (sch_cake) qdisc Dave Taht
2017-11-22 0:55 ` Dave Taht
2017-11-22 2:33 ` Ryan Mounce
2017-11-22 7:46 ` Toke Høiland-Jørgensen
2017-11-22 0:09 ` [Cake] [PATCH 3/3] Add support for building the new cake qdisc Dave Taht
2017-11-22 11:02 ` [Cake] [PATCH 0/3] Add Common Applications Kept Enhanced (sch_cake) qdisc Sebastian Moeller
2017-11-22 18:03 ` Dave Taht
2017-11-23 7:54 ` Sebastian Moeller
2017-11-23 21:43 ` Sebastian Moeller
2017-11-23 22:02 ` Sebastian Moeller
2017-11-23 22:20 ` Sebastian Moeller
2017-11-23 22:26 ` Dave Taht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121165513.036b01da@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=cake@lists.bufferbloat.net \
--cc=dave.taht@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox