From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Dave Taht <dave@taht.net>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
cake@lists.bufferbloat.net
Subject: Re: [Cake] [PATCH 1/3] pkt_sched.h: add support for sch_cake API
Date: Fri, 24 Nov 2017 11:33:18 -0200 [thread overview]
Message-ID: <20171124133317.GB32400@localhost.localdomain> (raw)
In-Reply-To: <87shd7ruwh.fsf@nemesis.taht.net>
On Tue, Nov 21, 2017 at 04:58:54PM -0800, Dave Taht wrote:
> Stephen Hemminger <stephen@networkplumber.org> writes:
...
> > Also, when I see multiple arrays of same size. It seems the API should
> > be:
> > struct tc_cake_tin_stats {
> > __u32 threshold_rate;
> > __u32 target_us;
> > struct tc_cake_traffic_stats sent;
> > ...
> >
> > What if you want to change number of TINS, the ABI shouldn't have to change.
>
> It is hard to imagine ever wanting more than 8 tins. Using up 3, sanely,
> has proven hard.
Which means each stats dump will almost always dump 5 empty TINS,
while if it were dynamic, it could dump only the 1, 2 or 3 in use and
probably help with the stats dump performance. Smaller slab, less
bytes to copy, ...
Marcelo
next prev parent reply other threads:[~2017-11-24 13:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 0:09 [Cake] [PATCH 0/3] Add Common Applications Kept Enhanced (sch_cake) qdisc Dave Taht
2017-11-22 0:09 ` [Cake] [PATCH 1/3] pkt_sched.h: add support for sch_cake API Dave Taht
2017-11-22 0:55 ` Stephen Hemminger
2017-11-22 0:58 ` Dave Taht
2017-11-22 21:38 ` Stephen Hemminger
2017-11-22 22:35 ` Dave Taht
2017-11-24 13:33 ` Marcelo Ricardo Leitner [this message]
2017-11-24 20:53 ` Dave Taht
[not found] ` <CAJq5cE2j9o1vHhxEecHkKMUv65d-BxDvXNJXPWh=WHmXVqNUQA@mail.gmail.com>
[not found] ` <CAJq5cE36nijxKM6dpRPK2d8axZwf=35a8D=2oArPjusRKALLpA@mail.gmail.com>
2017-11-22 6:59 ` Jonathan Morton
2017-11-22 0:09 ` [Cake] [PATCH 2/3] Add Common Applications Kept Enhanced (sch_cake) qdisc Dave Taht
2017-11-22 0:55 ` Dave Taht
2017-11-22 2:33 ` Ryan Mounce
2017-11-22 7:46 ` Toke Høiland-Jørgensen
2017-11-22 0:09 ` [Cake] [PATCH 3/3] Add support for building the new cake qdisc Dave Taht
2017-11-22 11:02 ` [Cake] [PATCH 0/3] Add Common Applications Kept Enhanced (sch_cake) qdisc Sebastian Moeller
2017-11-22 18:03 ` Dave Taht
2017-11-23 7:54 ` Sebastian Moeller
2017-11-23 21:43 ` Sebastian Moeller
2017-11-23 22:02 ` Sebastian Moeller
2017-11-23 22:20 ` Sebastian Moeller
2017-11-23 22:26 ` Dave Taht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171124133317.GB32400@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=dave@taht.net \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox