From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x22a.google.com (mail-qk0-x22a.google.com [IPv6:2607:f8b0:400d:c09::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id CCB773B2A4 for ; Fri, 24 Nov 2017 08:33:23 -0500 (EST) Received: by mail-qk0-x22a.google.com with SMTP id 136so24553357qkd.4 for ; Fri, 24 Nov 2017 05:33:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LmYv1RL7Lw41EIxoafu8OwCRVYJkppUmRE7ALJEJUYc=; b=ZSk0ypG2225pkT9kocfJUCeFyZZz+8KqO1E9UVsg4IB7SbspqvmtMIaHSGHI26MqJQ VwIOv9d0Xbv3DkGdDOg8P/C7aRmXIrUBcyEwpIhSB82yvRdwSC3c5pJi2r0JK8/yxiez d8L/O7daZCBZtCn6AgIRc1PadE4v2B6VuM5OQ9IhpbLxpo9YzaU+5Kquv+4pAUNS/KHS Y8Td+ovy0QWylVDLI7VNnRHEikGYpYr5zEAHUDnCCzCsJNKIcIQ/kXEpdiS/KMY7vBTg m0QoJ2JbyLHnzLUQso0UezIrKVX4vBAEDDlubOnhmr71RncEOgOdFogUB3/ZFk2/NAxT 4xxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LmYv1RL7Lw41EIxoafu8OwCRVYJkppUmRE7ALJEJUYc=; b=KTmPaqvRbu99xAhfJ2ifuJl7/VINkoeXQRf32i4br98fsDWYBYChuYasVYA88u6yN7 gaMRBffAITqF+l3wa30Vins1FydagzjjTC8VKsiKSlBdHB+0nKn4rDUnlomhHMXGF+HB s13Mm1ID50MWqEyhxrUeyj22hO67AiYRLs8WGfeXigksDH4b/PNUtO7JxXfln+mnGt+n GIl1a/OHHWIxQQ3ToNRgMlEuK4BPTZw6PmI0OiW8DDO0FwzHKCS4mCAVS7XYgY3hnBv0 hpuHxB7n7tl7/+dfjpVI/SmJy2LD6pagRSX9RE+6P7e7Nw8g9Z0Ys6VD1XhraQSfGj9F bLOw== X-Gm-Message-State: AJaThX6ZNPyfx8D2BGoilYfGL+dAQinj20ZOeJBxokuTyWweCr8DtF6Q DrT+3ktn0UNjvpOnptbiRNDxzw== X-Google-Smtp-Source: AGs4zMZojNz4/L50TGDPysxM8Zky4xiA/PdYk/hti4KChl/0hHGdEvvm6eT/ftllPzDjuY9JhWossQ== X-Received: by 10.55.169.210 with SMTP id s201mr44259189qke.124.1511530403035; Fri, 24 Nov 2017 05:33:23 -0800 (PST) Received: from mail.localdomain ([177.42.99.145]) by smtp.gmail.com with ESMTPSA id d79sm243962qkb.58.2017.11.24.05.33.22 (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 24 Nov 2017 05:33:22 -0800 (PST) Received: from mail.propriete.com.br (localhost [127.0.0.1]) by mail.localdomain (Postfix) with ESMTP id A8BE255B17; Fri, 24 Nov 2017 11:33:19 -0200 (BRST) Received: from localhost.localdomain (unknown [168.181.50.140]) by mail.propriete.com.br (Postfix) with ESMTPSA id 801434C1F9; Fri, 24 Nov 2017 11:33:19 -0200 (BRST) Date: Fri, 24 Nov 2017 11:33:18 -0200 From: Marcelo Ricardo Leitner To: Dave Taht Cc: Stephen Hemminger , cake@lists.bufferbloat.net Message-ID: <20171124133317.GB32400@localhost.localdomain> References: <1511309382-24060-1-git-send-email-dave.taht@gmail.com> <1511309382-24060-2-git-send-email-dave.taht@gmail.com> <20171121165513.036b01da@xeon-e3> <87shd7ruwh.fsf@nemesis.taht.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87shd7ruwh.fsf@nemesis.taht.net> User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [Cake] [PATCH 1/3] pkt_sched.h: add support for sch_cake API X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Nov 2017 13:33:23 -0000 On Tue, Nov 21, 2017 at 04:58:54PM -0800, Dave Taht wrote: > Stephen Hemminger writes: ... > > Also, when I see multiple arrays of same size. It seems the API should > > be: > > struct tc_cake_tin_stats { > > __u32 threshold_rate; > > __u32 target_us; > > struct tc_cake_traffic_stats sent; > > ... > > > > What if you want to change number of TINS, the ABI shouldn't have to change. > > It is hard to imagine ever wanting more than 8 tins. Using up 3, sanely, > has proven hard. Which means each stats dump will almost always dump 5 empty TINS, while if it were dynamic, it could dump only the 1, 2 or 3 in use and probably help with the stats dump performance. Smaller slab, less bytes to copy, ... Marcelo