Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
	"cake@lists.bufferbloat.net" <cake@lists.bufferbloat.net>
Subject: Re: [Cake] [PATCH 1/2] cake: print_uint format fixes
Date: Sun, 11 Mar 2018 16:34:23 -0700	[thread overview]
Message-ID: <20180311163423.2e8d63b6@xeon-e3> (raw)
In-Reply-To: <5DD63A68-EE32-4A5C-B08E-019FB8CBC9B1@darbyshire-bryant.me.uk>

On Sun, 11 Mar 2018 22:10:51 +0000
Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> wrote:

>  negative?  
> 
> Tried it, and you’d sort of guess wrong.  I’ll write it up tomorrow ‘properly’ but ‘int’ is int length whereas uint is uint64 length.  On big endian it goes wrong.
> 
> Anyway, glad you’ve tested on something little endian.  I’ll try to submit a patch upstream as requested…very busy over next 3 days doing $dayjob so may take a little while.  Thanks for boosting confidence that I’ve not broken it on architectures it used to work on :-)

print_uint should be unsigned only.

When printing json your version won't work with negative values.

  reply	other threads:[~2018-03-11 23:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-11  9:19 [Cake] fixing tc cake output since json-ification Kevin Darbyshire-Bryant
2018-03-11  9:19 ` [Cake] [PATCH 1/2] cake: print_uint format fixes Kevin Darbyshire-Bryant
2018-03-11 20:49   ` Toke Høiland-Jørgensen
2018-03-11 22:10     ` Kevin Darbyshire-Bryant
2018-03-11 23:34       ` Stephen Hemminger [this message]
2018-03-12  9:28         ` Kevin Darbyshire-Bryant
2018-03-12  9:56           ` Toke Høiland-Jørgensen
2018-03-12 15:11             ` Stephen Hemminger
2018-03-12 15:38               ` Toke Høiland-Jørgensen
2018-03-12 21:44                 ` Kevin Darbyshire-Bryant
2018-03-16  8:02               ` Kevin Darbyshire-Bryant
2018-03-17 14:33                 ` Toke Høiland-Jørgensen
2018-03-11  9:19 ` [Cake] [PATCH 2/2] tc " Kevin Darbyshire-Bryant
2018-03-11 20:50   ` Toke Høiland-Jørgensen
2018-03-11 20:57     ` Kevin Darbyshire-Bryant
2018-03-11 21:22       ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180311163423.2e8d63b6@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=cake@lists.bufferbloat.net \
    --cc=kevin@darbyshire-bryant.me.uk \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox