From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-x242.google.com (mail-pf0-x242.google.com [IPv6:2607:f8b0:400e:c00::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id BB9E03CB4F for ; Sun, 11 Mar 2018 19:34:26 -0400 (EDT) Received: by mail-pf0-x242.google.com with SMTP id m68so434972pfm.11 for ; Sun, 11 Mar 2018 16:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3Si4DZTAlJ9To+ddCqhyr1PajweW5G5V8+wJoZqeUcg=; b=RPsXxlfTguzmUW7SpYwsfHsLpQjAfQa0cocL1vGGe9beRtHmOASE63TOVCd7WSowFK n8t4uE38CnassweW5HuiVHxSWBh12Ny9oP3TxEIa9LWKs+R9UvDyDeIFf3y0LHcJBKSg o40tve/WrKF9uE3g+f46rpF3QZDrPr3oHaXrqsmFHWyks43oOBGlcWBMNIQNJ62NV2K/ hj0z0+FHaIF7cvcJRnZ4TBLx1uBGAEySS+NsuX3MXOU51UsueL2iR2vMMI9RTxtBbjJV e4kIJKFmUx2iW/nSX5KwsrATIhTguEkVvVjvKLHuIyI59I1UihivpeyulTiaT+j8HQMg HEyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3Si4DZTAlJ9To+ddCqhyr1PajweW5G5V8+wJoZqeUcg=; b=WxBcj/MBpe9wCte0t4k4ELL8jhrn3N+i1pMqkkr9S1wxJoMsEkbzKbI6ygYVrUmrM9 hrkB7CcbH+lD0fZFPm2sUt+o3znlyoslz6HYGBI80TQUhVFiGxaf/QLJ+xiS4Hb8tE2x G6K1YnA3oaf/BE/zMmz2OXbVpivyckvimE483XGq0XFeu36yU1TEBF8OjI+Oq7XoUtbr g8Jp0AyrKKn440CU4wa7uMDEPaKzjAMFxxJpKM4C6Lo+FQNNuHsg9JxQvmW1BO6NuUN0 L+821gIVZ7XaSh7E5eQ9i3V4SZfxBdRc2iO2t7uObScLXttV00oOqfFt+K8um4SgBIJA HY7g== X-Gm-Message-State: AElRT7Hz9RwLirkgwZBuhQDlIW8F822iXx04pH1ZvarqAN1dzB0/jTIF VltF20nW6Ol+gfTQNNx5L63epXFwGE8= X-Google-Smtp-Source: AG47ELvGtdhx8dfHdZXvNqZp2z+0CnVNzpILF2MCcRsm1y+7EPChHbgea72yew1LZwaxCKmnBTgfqA== X-Received: by 10.98.152.86 with SMTP id q83mr5979169pfd.218.1520811265879; Sun, 11 Mar 2018 16:34:25 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id b72sm13441573pfl.21.2018.03.11.16.34.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 11 Mar 2018 16:34:25 -0700 (PDT) Date: Sun, 11 Mar 2018 16:34:23 -0700 From: Stephen Hemminger To: Kevin Darbyshire-Bryant Cc: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= , "cake@lists.bufferbloat.net" Message-ID: <20180311163423.2e8d63b6@xeon-e3> In-Reply-To: <5DD63A68-EE32-4A5C-B08E-019FB8CBC9B1@darbyshire-bryant.me.uk> References: <20180311091930.86264-1-ldir@darbyshire-bryant.me.uk> <20180311091930.86264-2-ldir@darbyshire-bryant.me.uk> <87bmfujq18.fsf@toke.dk> <5DD63A68-EE32-4A5C-B08E-019FB8CBC9B1@darbyshire-bryant.me.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH 1/2] cake: print_uint format fixes X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Mar 2018 23:34:26 -0000 On Sun, 11 Mar 2018 22:10:51 +0000 Kevin Darbyshire-Bryant wrote: > negative? =20 >=20 > Tried it, and you=E2=80=99d sort of guess wrong. I=E2=80=99ll write it u= p tomorrow =E2=80=98properly=E2=80=99 but =E2=80=98int=E2=80=99 is int leng= th whereas uint is uint64 length. On big endian it goes wrong. >=20 > Anyway, glad you=E2=80=99ve tested on something little endian. I=E2=80= =99ll try to submit a patch upstream as requested=E2=80=A6very busy over ne= xt 3 days doing $dayjob so may take a little while. Thanks for boosting co= nfidence that I=E2=80=99ve not broken it on architectures it used to work o= n :-) print_uint should be unsigned only. When printing json your version won't work with negative values.