From: Stephen Hemminger <stephen@networkplumber.org>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
Subject: Re: [Cake] [PATCH iproute2-next v3] Add support for cake qdisc
Date: Tue, 24 Apr 2018 07:45:52 -0700 [thread overview]
Message-ID: <20180424074552.397564a5@xeon-e3> (raw)
In-Reply-To: <20180424123046.21247-1-toke@toke.dk>
On Tue, 24 Apr 2018 14:30:46 +0200
Toke Høiland-Jørgensen <toke@toke.dk> wrote:
> +static void cake_print_json_tin(struct tc_cake_tin_stats *tst, uint version)
> +{
> + open_json_object(NULL);
> + print_uint(PRINT_JSON, "threshold_rate", NULL, tst->threshold_rate);
> + print_uint(PRINT_JSON, "target", NULL, tst->target_us);
> + print_uint(PRINT_JSON, "interval", NULL, tst->interval_us);
> + print_uint(PRINT_JSON, "peak_delay", NULL, tst->peak_delay_us);
> + print_uint(PRINT_JSON, "average_delay", NULL, tst->avge_delay_us);
> + print_uint(PRINT_JSON, "base_delay", NULL, tst->base_delay_us);
> + print_uint(PRINT_JSON, "sent_packets", NULL, tst->sent.packets);
> + print_uint(PRINT_JSON, "sent_bytes", NULL, tst->sent.bytes);
> + print_uint(PRINT_JSON, "way_indirect_hits", NULL, tst->way_indirect_hits);
> + print_uint(PRINT_JSON, "way_misses", NULL, tst->way_misses);
> + print_uint(PRINT_JSON, "way_collisions", NULL, tst->way_collisions);
> + print_uint(PRINT_JSON, "drops", NULL, tst->dropped.packets);
> + print_uint(PRINT_JSON, "ecn_mark", NULL, tst->ecn_marked.packets);
> + print_uint(PRINT_JSON, "ack_drops", NULL, tst->ack_drops.packets);
> + print_uint(PRINT_JSON, "sparse_flows", NULL, tst->sparse_flows);
> + print_uint(PRINT_JSON, "bulk_flows", NULL, tst->bulk_flows);
> + print_uint(PRINT_JSON, "unresponsive_flows", NULL, tst->unresponse_flows);
> + print_uint(PRINT_JSON, "max_pkt_len", NULL, tst->max_skblen);
> + if (version >= 0x102)
> + print_uint(PRINT_JSON, "flow_quantum", NULL, tst->flow_quantum);
Please don't version objects in netlink. That is not how netlink is
supposed to be used.
next prev parent reply other threads:[~2018-04-24 14:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-03 22:06 [Cake] [PATCH net-next 0/3] Add Common Applications Kept Enhanced (cake) qdisc Dave Taht
2017-12-03 22:06 ` [Cake] [PATCH net-next 1/3] pkt_sched.h: add support for sch_cake API Dave Taht
2017-12-03 22:06 ` [Cake] [PATCH net-next 2/3] Add Common Applications Kept Enhanced (cake) qdisc Dave Taht
2017-12-03 22:06 ` [Cake] [PATCH net-next 3/3] Add support for building the new cake qdisc Dave Taht
[not found] ` <201712051010.18kFjMiy%fengguang.wu@intel.com>
2017-12-05 4:48 ` Dave Taht
2018-04-24 11:44 ` [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-04-24 11:44 ` [Cake] [PATCH iproute2-next v2] Add support for cake qdisc Toke Høiland-Jørgensen
2018-04-24 12:30 ` [Cake] [PATCH iproute2-next v3] " Toke Høiland-Jørgensen
2018-04-24 14:44 ` Stephen Hemminger
2018-04-24 14:45 ` Stephen Hemminger [this message]
2018-04-24 14:52 ` Toke Høiland-Jørgensen
2018-04-24 15:10 ` Stephen Hemminger
2018-04-24 15:38 ` Toke Høiland-Jørgensen
2018-04-24 15:11 ` [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc Stephen Hemminger
2018-04-24 15:14 ` Stephen Hemminger
2018-04-24 15:32 ` Georgios Amanakis
2018-04-24 15:41 ` Toke Høiland-Jørgensen
[not found] ` <CACvFP_hzHY+=qPh6_=_++UhbnAU1xjPguY7fNzG0TSVhYm0V3Q@mail.gmail.com>
2018-04-24 15:51 ` Georgios Amanakis
2018-04-24 16:03 ` Toke Høiland-Jørgensen
2018-04-26 19:16 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424074552.397564a5@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=cake@lists.bufferbloat.net \
--cc=netdev@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox