From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-x22a.google.com (mail-pg0-x22a.google.com [IPv6:2607:f8b0:400e:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 4D0083B29E for ; Tue, 24 Apr 2018 10:45:55 -0400 (EDT) Received: by mail-pg0-x22a.google.com with SMTP id i194so11049573pgd.0 for ; Tue, 24 Apr 2018 07:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cYrfKjkeX6Wtf/L3RBWC1DJD+irAwa6DK3RyMqPBEPo=; b=g4ggD2VrYBX/0zDM7d3LXaNoq+w27JcmSmw7F4D+Wt8YfOgtFs2ZFz69RCPxuHmT0t zqZg6pPYhiIsjNN36sncSzi2Kslgm8IIz2iEYJWT7dRCwpSTNOfeQydulMEKweAcgibj Pa3m/YrJWDHWU6NYayVnt5txMu0DSwAhhyDOu3gbPeTBqQhDWNADxiImp9EAUyvLTHcS Dvpf7yw1nQUcCCSgZMXH11F7mvcenro4tObrC7sp2/8Nlb9ptFTe3c3rXVRiTE4py1B2 zBdyc80lw7N4jdDRFhahWvr1K6JNwR/y8bqacbkPcKWJ4naqWJ2pO77dXWqOZDORvMIN Iv7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cYrfKjkeX6Wtf/L3RBWC1DJD+irAwa6DK3RyMqPBEPo=; b=IP/g3flvpUgGsRqAB8QPMbqrN6yBqx4bJL47qF4UfppzBPvP33mFOBfFBLLOS95XF8 n+1VFE6IZuodOrtdOVSqCY08n3kMsUK9lsYi+f2KgOve8hwPRWodqO2NNj8GLXtbMLAk ZCNHX98q3d21IpV5d8Vn11/cisCgQo7yKq7nde0hO2FisP9u34oQB7MFxfK+9PaSkH4z tvzPy8iIwksr7nRw6czkbUv5ypXDG7a7jvCdjURH0pI0ZgD2+wHTULKOJ4m2XqAVji0l xVqvFTa6lyrtUJltlyVtmfqtxBbI2RyrabLUuOTCCQQWn6ZagSYcDoNAxTY5Z6sg6bHj IvNw== X-Gm-Message-State: ALQs6tDA2FJoSzSOaoOW4CGsL+556I365yYbW6Eo1nTcdbkNZcPOikl7 OJYqYzT4zdekUm4ul9qHRBAEhRpBVHs= X-Google-Smtp-Source: AIpwx4/iWga0YGamGuu7LlYC4VJefre65OeRN0DaTo5rmnGeSrpwuMvL9WY2B+knhkkOxewEZd8noQ== X-Received: by 10.99.111.65 with SMTP id k62mr20249123pgc.73.1524581154405; Tue, 24 Apr 2018 07:45:54 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id p86sm29300261pfi.148.2018.04.24.07.45.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Apr 2018 07:45:54 -0700 (PDT) Date: Tue, 24 Apr 2018 07:45:52 -0700 From: Stephen Hemminger To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net Message-ID: <20180424074552.397564a5@xeon-e3> In-Reply-To: <20180424123046.21247-1-toke@toke.dk> References: <20180424114407.5939-2-toke@toke.dk> <20180424123046.21247-1-toke@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH iproute2-next v3] Add support for cake qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 14:45:55 -0000 On Tue, 24 Apr 2018 14:30:46 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > +static void cake_print_json_tin(struct tc_cake_tin_stats *tst, uint vers= ion) > +{ > + open_json_object(NULL); > + print_uint(PRINT_JSON, "threshold_rate", NULL, tst->threshold_rate); > + print_uint(PRINT_JSON, "target", NULL, tst->target_us); > + print_uint(PRINT_JSON, "interval", NULL, tst->interval_us); > + print_uint(PRINT_JSON, "peak_delay", NULL, tst->peak_delay_us); > + print_uint(PRINT_JSON, "average_delay", NULL, tst->avge_delay_us); > + print_uint(PRINT_JSON, "base_delay", NULL, tst->base_delay_us); > + print_uint(PRINT_JSON, "sent_packets", NULL, tst->sent.packets); > + print_uint(PRINT_JSON, "sent_bytes", NULL, tst->sent.bytes); > + print_uint(PRINT_JSON, "way_indirect_hits", NULL, tst->way_indirect_hit= s); > + print_uint(PRINT_JSON, "way_misses", NULL, tst->way_misses); > + print_uint(PRINT_JSON, "way_collisions", NULL, tst->way_collisions); > + print_uint(PRINT_JSON, "drops", NULL, tst->dropped.packets); > + print_uint(PRINT_JSON, "ecn_mark", NULL, tst->ecn_marked.packets); > + print_uint(PRINT_JSON, "ack_drops", NULL, tst->ack_drops.packets); > + print_uint(PRINT_JSON, "sparse_flows", NULL, tst->sparse_flows); > + print_uint(PRINT_JSON, "bulk_flows", NULL, tst->bulk_flows); > + print_uint(PRINT_JSON, "unresponsive_flows", NULL, tst->unresponse_flow= s); > + print_uint(PRINT_JSON, "max_pkt_len", NULL, tst->max_skblen); > + if (version >=3D 0x102) > + print_uint(PRINT_JSON, "flow_quantum", NULL, tst->flow_quantum); Please don't version objects in netlink. That is not how netlink is supposed to be used.