From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-x231.google.com (mail-pf0-x231.google.com [IPv6:2607:f8b0:400e:c00::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 439243B29E for ; Tue, 24 Apr 2018 11:10:12 -0400 (EDT) Received: by mail-pf0-x231.google.com with SMTP id o16so12501659pfk.9 for ; Tue, 24 Apr 2018 08:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=f1Que1Tr5A57KUa1UVMDaJXsOWpSJIjPss62rXuz4z0=; b=L+wU1GecyiVTECY3LMjAoYXSlixOhI7KPBFb2a+7hTKVcHrSOHxSsh4R5/3ECNjouu kUICz7ZKQHS1C7K1Lemcwm23hFvktThcSIUZN7XLXwXEMWGX454yQaJ4jdo80QAtgpne rB00+567rvR5xTQ+2iKuO66HTTKmnqngGKuvAPweIlo1CFCNBePB8dQKbPtGk8qu82gU md0nrTdCL9tpZH69gocMrESwGG17xwD8om8yWcw612b7BPJ5jjNMFdNq15OUNaEzFOgA 3ZUzLsV6GA7Ms3jzoToM6xRzae0Mudzo199/hNyQI2vtKlTWo1kDolYgfjhPMjKgrM0G mroA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f1Que1Tr5A57KUa1UVMDaJXsOWpSJIjPss62rXuz4z0=; b=W5pk4ICCvErAjcI64jwVBvbm66uzPYjNtiucibEhnUExQop/e2tLPeuF/cC1YQ+evK 5k363gvGmer7m+62B0AhybCGwRMt3ATtRNXyGvgnlABoaAHkFUnM6D88Tnaa6DkaGcOH diZe5ZJ/dfZIcLunWHvA11iOA/YGhUcoJO6Mdij+jyxvE+yTn/FlKZqUFGefw4Gvq4xb yuxQBUNT8HmtAAKlvrurmrukGQpb+ZL74wrPfdqir2N+xtH4X6Dl7ShHfa6jkSDADwsl B8rqhoFzrzgrd3ZB5g8nD/OvgDeIyGXffG+tJHSxVDTJ8BN54EIvtmuMabqHdpYOhB+R NblQ== X-Gm-Message-State: ALQs6tALOzz86M7J8NaTqDxxAPaKq3nZ3L3Nirs9putDk3veiPC209eI P7Nk3HVaJHcjtPgjzKtQe43LEA== X-Google-Smtp-Source: AB8JxZoPNa5wd2VgofCxtkU9D3bqZ9lWiIbKCYSBHD2uKJd0U102USlC92aJZVI9jlgOF30yWCe+ug== X-Received: by 2002:a17:902:b2c8:: with SMTP id x8-v6mr2144544plw.3.1524582611382; Tue, 24 Apr 2018 08:10:11 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id v16sm25886039pfj.123.2018.04.24.08.10.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Apr 2018 08:10:11 -0700 (PDT) Date: Tue, 24 Apr 2018 08:10:08 -0700 From: Stephen Hemminger To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net Message-ID: <20180424081008.2ad7eaa7@xeon-e3> In-Reply-To: <87efj47j1y.fsf@toke.dk> References: <20180424114407.5939-2-toke@toke.dk> <20180424123046.21247-1-toke@toke.dk> <20180424074552.397564a5@xeon-e3> <87efj47j1y.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH iproute2-next v3] Add support for cake qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 15:10:12 -0000 On Tue, 24 Apr 2018 16:52:57 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > Well, this is leftover from keeping track of different versions of the > out-of-tree patch, and we already broke compatibility pretty thoroughly > as a preparation for upstreaming. So I'm fine with dropping the version > check; will resend. >=20 > That being said, the versioning comes from the XSTATS API, which does > not use netlink attributes for its members, but rather passes through as > struct. So what is one supposed to do in this case? If a structure is likely to change, then it should be decomposed into nested netlink attributes. Once you send a structure over userspace API in netlink it is fixed forever.