From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-x229.google.com (mail-pf0-x229.google.com [IPv6:2607:f8b0:400e:c00::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 047F33B29E for ; Tue, 24 Apr 2018 11:11:29 -0400 (EDT) Received: by mail-pf0-x229.google.com with SMTP id p6so12506447pfn.4 for ; Tue, 24 Apr 2018 08:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KH27xEvOfAhUJEgliJBV5uKe16BD3ITWATPFzPYfRqU=; b=vP/zMOCKf9kuYscJyb1+50ShI5ICyNHhuGjsNI+ri7sXfqOolqgyQYoc9Vz7fk/KMd nqRy2rKwLqzo119/RjeOP+vZQCUaLGYhk7RffyVqkGQiovMxRT7eAe8+cEO5d2uHg82n MpH5Cpv05nHeCr9wQ+H1vfhpI2U9LIyGPf+3eOdU9hPv9uwZQ1+Zy/h8WU8gRT478SIB OIDbJGNIVkkrWhpf+Rd8PozGTKluapWHkoUuUV808FiKVrMm+hQwTCdYryGCz25/3/e5 ov9nWJb6YjC57sdYR/GWXzyC3z9KF3kguPREn90AMAChC3MNXJGMtDvyC408dzoDY7F+ JDLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KH27xEvOfAhUJEgliJBV5uKe16BD3ITWATPFzPYfRqU=; b=VrFgKPoaQM0ymaGXJYZRlayx75K6/UwyoFm673olLbEgi65BTroXKi8+fQ/tpFUD3u btLocTa54AH9jQYp0wphQrapF3nQBe14S9gKh8z/l/iWAuogmBlcXuHTc5Ti46KxiKm2 QpcQ6fh2VXRI0/OfA5qLc7K4PVWWBxDlmKOtT9H1zqidOPnRs1bNMWibsxh9oaozp/zK NDSlNZOf39MLs3Xa+OUkfcwblAkW0L2AEEtoK+Ya77rSub+jPBj/mRK5bp18qGeOtxDf 6tNXBqea8P/Glf1qQvCmPTXysQhaTj+iP5KulmSDc/PfLZTs3MuxIPFlLrX07AVUYSKQ J/GQ== X-Gm-Message-State: ALQs6tDzbV+LRv3mfyGPFrnXg9HxN6RiWf0xMm1eXUWNGolriR/OxYZq Adc9LqMHxvf490Z4Q0B1f8uYng== X-Google-Smtp-Source: AIpwx48qENGUacMnjtHr8VdluFBcX/MhtEA/oBB7LNqGIOQtM697oOF9NjrBdCYhddj3F5mxTX3mGQ== X-Received: by 2002:a17:902:42a5:: with SMTP id h34-v6mr25202658pld.65.1524582689033; Tue, 24 Apr 2018 08:11:29 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id c12sm24217686pfn.13.2018.04.24.08.11.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Apr 2018 08:11:28 -0700 (PDT) Date: Tue, 24 Apr 2018 08:11:26 -0700 From: Stephen Hemminger To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net Message-ID: <20180424081126.2e2f830a@xeon-e3> In-Reply-To: <20180424114407.5939-1-toke@toke.dk> References: <1512338775-3270-1-git-send-email-dave.taht@gmail.com> <20180424114407.5939-1-toke@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 15:11:30 -0000 On Tue, 24 Apr 2018 13:44:06 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > +struct tc_cake_xstats { > + __u16 version; > + __u16 tin_stats_size; /* =3D=3D sizeof(struct tc_cake_tin_stats) */ > + __u32 capacity_estimate; > + __u32 memory_limit; > + __u32 memory_used; > + __u8 tin_cnt; > + __u8 avg_trnoff; > + __u16 max_netlen; > + __u16 max_adjlen; > + __u16 min_netlen; > + __u16 min_adjlen; > + > + __u16 spare1; > + __u32 spare2; > + > + struct tc_cake_tin_stats tin_stats[0]; /* keep last */ > +}; No versioning allowed in userspace API. You need to drop version and make it permanent.