From: Stephen Hemminger <stephen@networkplumber.org>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
Subject: Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc
Date: Tue, 24 Apr 2018 08:14:06 -0700 [thread overview]
Message-ID: <20180424081406.5127f1bc@xeon-e3> (raw)
In-Reply-To: <20180424114407.5939-1-toke@toke.dk>
On Tue, 24 Apr 2018 13:44:06 +0200
Toke Høiland-Jørgensen <toke@toke.dk> wrote:
> +static const u8 precedence[] = {0, 0, 0, 0, 0, 0, 0, 0,
> + 1, 1, 1, 1, 1, 1, 1, 1,
> + 2, 2, 2, 2, 2, 2, 2, 2,
> + 3, 3, 3, 3, 3, 3, 3, 3,
> + 4, 4, 4, 4, 4, 4, 4, 4,
> + 5, 5, 5, 5, 5, 5, 5, 5,
> + 6, 6, 6, 6, 6, 6, 6, 6,
> + 7, 7, 7, 7, 7, 7, 7, 7,
> + };
Minor nit. The kernel style for initializing array should be used
here.
static const u8 precedence[] = {
0, 0, 0, 0, 0, 0, 0, 0,
1, 1, 1, 1, 1, 1, 1, 1,
...
};
next prev parent reply other threads:[~2018-04-24 15:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-03 22:06 [Cake] [PATCH net-next 0/3] " Dave Taht
2017-12-03 22:06 ` [Cake] [PATCH net-next 1/3] pkt_sched.h: add support for sch_cake API Dave Taht
2017-12-03 22:06 ` [Cake] [PATCH net-next 2/3] Add Common Applications Kept Enhanced (cake) qdisc Dave Taht
2017-12-03 22:06 ` [Cake] [PATCH net-next 3/3] Add support for building the new cake qdisc Dave Taht
[not found] ` <201712051010.18kFjMiy%fengguang.wu@intel.com>
2017-12-05 4:48 ` Dave Taht
2018-04-24 11:44 ` [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-04-24 11:44 ` [Cake] [PATCH iproute2-next v2] Add support for cake qdisc Toke Høiland-Jørgensen
2018-04-24 12:30 ` [Cake] [PATCH iproute2-next v3] " Toke Høiland-Jørgensen
2018-04-24 14:44 ` Stephen Hemminger
2018-04-24 14:45 ` Stephen Hemminger
2018-04-24 14:52 ` Toke Høiland-Jørgensen
2018-04-24 15:10 ` Stephen Hemminger
2018-04-24 15:38 ` Toke Høiland-Jørgensen
2018-04-24 15:11 ` [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc Stephen Hemminger
2018-04-24 15:14 ` Stephen Hemminger [this message]
2018-04-24 15:32 ` Georgios Amanakis
2018-04-24 15:41 ` Toke Høiland-Jørgensen
[not found] ` <CACvFP_hzHY+=qPh6_=_++UhbnAU1xjPguY7fNzG0TSVhYm0V3Q@mail.gmail.com>
2018-04-24 15:51 ` Georgios Amanakis
2018-04-24 16:03 ` Toke Høiland-Jørgensen
2018-04-26 19:16 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424081406.5127f1bc@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=cake@lists.bufferbloat.net \
--cc=netdev@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox