From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com [IPv6:2607:f8b0:400e:c00::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 33AE83B29E for ; Tue, 24 Apr 2018 11:14:09 -0400 (EDT) Received: by mail-pf0-x241.google.com with SMTP id j5so12518315pfh.2 for ; Tue, 24 Apr 2018 08:14:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KJO+WY/LLwWBllidK9wIS0VgRH2vy3PYsyGITBGAdIY=; b=qHdRc0EmzOFy2VmcY5tSCP32yzWgGAhYrTL4+rS5CLQ9ZYnRZ/swwTytWj/fEq4msT RyqVAfVBDpDuazs+LtWQ8eKA2vsPk/RtT8WZ2JRla9BxWlqbjfX2WPgfZS2v6q39Af3A zWbnlHQIflS8SgOCB4YSP8lfDR7LOH5v2xTVvMptewxr7CdWUczcV1ZjsbA9+WiWaw+a oP0s6IobSeWlCtjY7k/xvtqcrhHeIqUJPuPVII8L4cmo0n/B+9zDkrX8G8Ux9uVooeJQ V01gp0P6SQ/sm9izHAOeryab4QTcwfbFUfvEgE537s/dPo1n0yIjCEkQckJ9ayAxkLFs umUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KJO+WY/LLwWBllidK9wIS0VgRH2vy3PYsyGITBGAdIY=; b=b+BksCzQP3+NEEsrtLFNXxudZIqelhXZUwE8SQFfM0NiLagT2yHl/Y6xG6VYvME83N V98fXEVYooMvFhHEsDAygL2cMSxTm6SZ1nCxcDGK2nz9OWMUDp388EsvtLW8/M8PRlB7 lucmOfsYhN4nrUQbCkoSzynSnlOHL5dzWzzhf3PSMsU9g6m8RSBkQ/tFiBQoPh4Dq4kQ F2yLUj0BoWgAcMyemLFuvc49uX77RvyX4lFkY0RrHy89iQknGdlsbMzDBa7NeyeXIM4C ttPOpSDOKND1CVr4yA5lZlRyoBSnjcLkzy/mNmCrH5cMiRqvK/S5UtHH5/9dQUmophCK nXeA== X-Gm-Message-State: ALQs6tBAQW8J3mwufDokqyZLeBKKVaW5IJKtD56DHvUPpYADH+tgnL8n JbxCLTNdlDy0wmx5aXpxuzcqHASHKWQ= X-Google-Smtp-Source: AB8JxZqqavoTyTAGG716xsX4whlSkgnYL7sp1CIV4YR/fifRRGCrx4sLV8/Q8hZ6m5nNm4E6zWpdcQ== X-Received: by 10.98.225.7 with SMTP id q7mr634320pfh.226.1524582848198; Tue, 24 Apr 2018 08:14:08 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id g76sm35053898pfj.102.2018.04.24.08.14.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Apr 2018 08:14:08 -0700 (PDT) Date: Tue, 24 Apr 2018 08:14:06 -0700 From: Stephen Hemminger To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net Message-ID: <20180424081406.5127f1bc@xeon-e3> In-Reply-To: <20180424114407.5939-1-toke@toke.dk> References: <1512338775-3270-1-git-send-email-dave.taht@gmail.com> <20180424114407.5939-1-toke@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 15:14:09 -0000 On Tue, 24 Apr 2018 13:44:06 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > +static const u8 precedence[] =3D {0, 0, 0, 0, 0, 0, 0, 0, > + 1, 1, 1, 1, 1, 1, 1, 1, > + 2, 2, 2, 2, 2, 2, 2, 2, > + 3, 3, 3, 3, 3, 3, 3, 3, > + 4, 4, 4, 4, 4, 4, 4, 4, > + 5, 5, 5, 5, 5, 5, 5, 5, > + 6, 6, 6, 6, 6, 6, 6, 6, > + 7, 7, 7, 7, 7, 7, 7, 7, > + }; Minor nit. The kernel style for initializing array should be used here. static const u8 precedence[] =3D { 0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, 1, 1, 1, 1, ... };