From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-x235.google.com (mail-pg0-x235.google.com [IPv6:2607:f8b0:400e:c05::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 94BE83BA8E for ; Wed, 25 Apr 2018 21:32:03 -0400 (EDT) Received: by mail-pg0-x235.google.com with SMTP id b9so14624833pgf.6 for ; Wed, 25 Apr 2018 18:32:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xcZeh0z7TsFLg61EWt8dB7gMukBrSMKWPoAqVm5M56o=; b=pgHEbdson3VYS2nejH+phW9VJ19TjE+gno9/hZZgGJ9vmkmImErnn2RskcxOmgMmVt RSPJH3yhRx52xkIFWXo+NXgupYSrc2dqierW0lZXXEFDISSfBHkgZZzyvQO1HSmZbOdP V1S/NQW8bt1Pm0ev7YBImKZ36cHsy6mHDX4Wolh7I8jUPLnrScPuBqEk8GI2IUZGwg5v 2q5+DHGLcfHy9TpzENMOu6drkvbBETKeyMYxMShM0KyOgpEmC7BT8XxDzA006mJL0HT/ AxkYq1640xoc0lbQLXPaiIvffi1/NyLh8YxPHUS4fQGP7c3BEW9aUW7xwk1rFQ+bmXze I1Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xcZeh0z7TsFLg61EWt8dB7gMukBrSMKWPoAqVm5M56o=; b=WWheG5EKHndUNdsoJbLedBzomRqM153H0DVI2jlkjDyY4llMp2uQyIEcs1SXI6mFst A3MIkOLV7ONIHCgW00l+pwkOyX/CF81xomaxYDw9t6G3TX8FQWwwDFwYu8xblXchWfPs FPk31DGXAIYhUfAlnBRu9gMYTGrNcliHbFjiLjpMmJLlviuEzq4rRmvh+6tncUvQJPaI t+ZC4AGpko9seWB77vRuU8bCcVz50BhR/GXIfZRa5dBBTyYMQ7V8zLdfinHpbgF+G/Ko 8QhGkXVvvDz3BUZ5iyhI3CNJWCCPnIwYh8SiA6r4W2UBpCvYD4OLJ/RAVhWoY+JTTDYY eM1A== X-Gm-Message-State: ALQs6tBbVTNexBemTTW+KtvvMYifkQ2W1rnBoMUMvhLMasitiJWWuLV1 YY7SnVFeqwehc5pOvxER4kiMBQ== X-Google-Smtp-Source: AB8JxZpdpYcDGwXOf2cc9srSOPztCVN9+NmcUGyIQ8cF/+coxk2H970H9g8a+XNZTwu/aUVNorkxlg== X-Received: by 10.167.131.92 with SMTP id z28mr1108644pfm.237.1524706322638; Wed, 25 Apr 2018 18:32:02 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id u9sm38185240pfj.10.2018.04.25.18.32.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Apr 2018 18:32:02 -0700 (PDT) Date: Wed, 25 Apr 2018 18:32:00 -0700 From: Stephen Hemminger To: Ryan Mounce Cc: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= , Cake List Message-ID: <20180425183200.0877eaa2@xeon-e3> In-Reply-To: References: <87vacf3th7.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Cake] CAKE upstreaming - testers wanted, ACK filtering rescuers needed X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 01:32:03 -0000 On Thu, 26 Apr 2018 10:40:29 +0930 Ryan Mounce wrote: > I'll investigate making the ACK filtering code safe, it is my mess after all :) > > Eric obviously understands this stuff a lot better than me, it looks > like there are two issues? > - Lack of minimum length check for TCP header, should be fairly > straight-forward to fix > - The possibility of unsafely filtering part of a split GSO super-packet? > > Regards, > Ryan Mounce > > ryan@mounce.com.au > 0415 799 929 It makes more sense to move it out of Cake altogether. Cake is already one of those projects that seems to have Golden Hammer disease. https://en.wikipedia.org/wiki/Law_of_the_instrument Why not in netfilter or XDP? Then it could be used in other contexts like tunnels or selectively based on route etc.