Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: kbuild-all@01.org, netdev@vger.kernel.org,
	cake@lists.bufferbloat.net,
	"Toke Høiland-Jørgensen" <toke@toke.dk>,
	"Dave Taht" <dave.taht@gmail.com>
Subject: Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc
Date: Fri, 27 Apr 2018 03:16:32 +0800	[thread overview]
Message-ID: <201804270252.hLeQlRtz%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180424114407.5939-1-toke@toke.dk>

[-- Attachment #1: Type: text/plain, Size: 3367 bytes --]

Hi Toke,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/Add-Common-Applications-Kept-Enhanced-cake-qdisc/20180426-064653
config: parisc-allmodconfig (attached as .config)
compiler: hppa-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=parisc 

All warnings (new ones prefixed by >>):


vim +2589 net//sched/sch_cake.c

  2525	
  2526	static int cake_dump_stats(struct Qdisc *sch, struct gnet_dump *d)
  2527	{
  2528		struct cake_sched_data *q = qdisc_priv(sch);
  2529		struct tc_cake_xstats *st;
  2530		size_t size = (sizeof(*st) +
  2531			       sizeof(struct tc_cake_tin_stats) * q->tin_cnt);
  2532		int i;
  2533	
  2534		st = cake_zalloc(size);
  2535	
  2536		if (!st)
  2537			return -1;
  2538	
  2539		st->version = 0x102; /* old userspace code discards versions > 0xFF */
  2540		st->tin_stats_size = sizeof(struct tc_cake_tin_stats);
  2541		st->tin_cnt = q->tin_cnt;
  2542	
  2543		st->avg_trnoff = (q->avg_trnoff + 0x8000) >> 16;
  2544		st->max_netlen = q->max_netlen;
  2545		st->max_adjlen = q->max_adjlen;
  2546		st->min_netlen = q->min_netlen;
  2547		st->min_adjlen = q->min_adjlen;
  2548	
  2549		for (i = 0; i < q->tin_cnt; i++) {
  2550			struct cake_tin_data *b = &q->tins[q->tin_order[i]];
  2551			struct tc_cake_tin_stats *tstat = &st->tin_stats[i];
  2552	
  2553			tstat->threshold_rate = b->tin_rate_bps;
  2554			tstat->target_us      = cobalt_time_to_us(b->cparams.target);
  2555			tstat->interval_us    = cobalt_time_to_us(b->cparams.interval);
  2556	
  2557			/* TODO FIXME: add missing aspects of these composite stats */
  2558			tstat->sent.packets       = b->packets;
  2559			tstat->sent.bytes	  = b->bytes;
  2560			tstat->dropped.packets    = b->tin_dropped;
  2561			tstat->ecn_marked.packets = b->tin_ecn_mark;
  2562			tstat->backlog.bytes      = b->tin_backlog;
  2563			tstat->ack_drops.packets  = b->ack_drops;
  2564	
  2565			tstat->peak_delay_us = cobalt_time_to_us(b->peak_delay);
  2566			tstat->avge_delay_us = cobalt_time_to_us(b->avge_delay);
  2567			tstat->base_delay_us = cobalt_time_to_us(b->base_delay);
  2568	
  2569			tstat->way_indirect_hits = b->way_hits;
  2570			tstat->way_misses	 = b->way_misses;
  2571			tstat->way_collisions    = b->way_collisions;
  2572	
  2573			tstat->sparse_flows      = b->sparse_flow_count +
  2574						   b->decaying_flow_count;
  2575			tstat->bulk_flows	 = b->bulk_flow_count;
  2576			tstat->unresponse_flows  = b->unresponsive_flow_count;
  2577			tstat->spare		 = 0;
  2578			tstat->max_skblen	 = b->max_skblen;
  2579	
  2580			tstat->flow_quantum	 = b->flow_quantum;
  2581		}
  2582		st->capacity_estimate = q->avg_peak_bandwidth;
  2583		st->memory_limit      = q->buffer_limit;
  2584		st->memory_used       = q->buffer_max_used;
  2585	
  2586		i = gnet_stats_copy_app(d, st, size);
  2587		cake_free(st);
  2588		return i;
> 2589	}
  2590	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 52468 bytes --]

      parent reply	other threads:[~2018-04-26 19:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-03 22:06 [Cake] [PATCH net-next 0/3] " Dave Taht
2017-12-03 22:06 ` [Cake] [PATCH net-next 1/3] pkt_sched.h: add support for sch_cake API Dave Taht
2017-12-03 22:06 ` [Cake] [PATCH net-next 2/3] Add Common Applications Kept Enhanced (cake) qdisc Dave Taht
2017-12-03 22:06 ` [Cake] [PATCH net-next 3/3] Add support for building the new cake qdisc Dave Taht
     [not found]   ` <201712051010.18kFjMiy%fengguang.wu@intel.com>
2017-12-05  4:48     ` Dave Taht
2018-04-24 11:44 ` [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-04-24 11:44   ` [Cake] [PATCH iproute2-next v2] Add support for cake qdisc Toke Høiland-Jørgensen
2018-04-24 12:30     ` [Cake] [PATCH iproute2-next v3] " Toke Høiland-Jørgensen
2018-04-24 14:44       ` Stephen Hemminger
2018-04-24 14:45       ` Stephen Hemminger
2018-04-24 14:52         ` Toke Høiland-Jørgensen
2018-04-24 15:10           ` Stephen Hemminger
2018-04-24 15:38             ` Toke Høiland-Jørgensen
2018-04-24 15:11   ` [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc Stephen Hemminger
2018-04-24 15:14   ` Stephen Hemminger
2018-04-24 15:32     ` Georgios Amanakis
2018-04-24 15:41       ` Toke Høiland-Jørgensen
     [not found]         ` <CACvFP_hzHY+=qPh6_=_++UhbnAU1xjPguY7fNzG0TSVhYm0V3Q@mail.gmail.com>
2018-04-24 15:51           ` Georgios Amanakis
2018-04-24 16:03             ` Toke Høiland-Jørgensen
2018-04-26 19:16   ` kbuild test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201804270252.hLeQlRtz%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=dave.taht@gmail.com \
    --cc=kbuild-all@01.org \
    --cc=netdev@vger.kernel.org \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox