From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-x235.google.com (mail-pf0-x235.google.com [IPv6:2607:f8b0:400e:c00::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 64A7E3B29E for ; Fri, 27 Apr 2018 12:17:05 -0400 (EDT) Received: by mail-pf0-x235.google.com with SMTP id o76so1830599pfi.5 for ; Fri, 27 Apr 2018 09:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QAAu6hwzSw09ee0FBaScHCMrF2K1jD+K26kY2yIZuCo=; b=UOg66+rQyA2CBLVSGf1D9C1zljHap2omsoFNLj5NClm2PzGfLpwZ99b39BhEBVAV/g Obo5QOu/8TfBLOHP3rrz2q/btb8tLTjzBqTfx4Cia0+xJP6oHSgpJgpfwktulEALwiI8 ANz5jDYylyeVfz420DdwY4hvJjdWv9s+8sO6QWLog/VnCfgjwXMwSpKWKGe7H9PXY+pN +ReIz1uWtU8DDZC9JLhyJ6SVAtZYidGxdtgcTHiHzNApiy2F+HUmAes7Vhi6FF8jL9LR XG/k0Ei9w8Uu7Cx3ju3RINy/HaANHzrIpiaZCp2V5hM8CrnV3BKj2/iP8D0uQLwO7F11 l5uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QAAu6hwzSw09ee0FBaScHCMrF2K1jD+K26kY2yIZuCo=; b=khIz07XST/YDBzbgDJcv4AUipKUGhO2M1NzGr9vRq1DJT9SqUnbDMurtK41fJyACzJ PjW8hS6AewktwJXNA0wTCsIHHmzyijoXj3AzsXlwe1/PEM1E3sIoS6dYl7+bTeQdCnCs Oa81CAYU/S1xftbzlWrKzr+HlyzWK6D4P/ppRs1EiRxuLXyqIFg+bJeql9goHYh/wR/S NEmcSoSIW0R9Tz9TwZvboIg1UUKa58x705spVfwKebv8nn5fMAp58Qk+JvQkzcgKrOeY IRRJjcJWOO9z5jcCu8IUikjVT1EKR8XElvn4gYqeIOYmxRX8MKfFfejNVIjzUSC4dtoA qHYw== X-Gm-Message-State: ALQs6tC6ofh4NMyJAaNGQ84pUZbD3i/Ci0DfXxIeJuqHYeX/XpVr/qIC qc1nHwt5UmfevUxUNho9JtaloQ== X-Google-Smtp-Source: AB8JxZoVrNeNEWNfm4oh5oWQoxp+Ke37vL0peZTNY+QiyLqbSmM0FzFLa9O527TR+LQ5IXov8aBjiw== X-Received: by 2002:a63:43c6:: with SMTP id q189-v6mr2716961pga.123.1524845824472; Fri, 27 Apr 2018 09:17:04 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id z127sm3238562pfb.72.2018.04.27.09.17.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Apr 2018 09:17:04 -0700 (PDT) Date: Fri, 27 Apr 2018 09:17:02 -0700 From: Stephen Hemminger To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net Message-ID: <20180427091702.2e91a5dc@xeon-e3> In-Reply-To: <20180427121706.23273-2-toke@toke.dk> References: <20180427121706.23273-1-toke@toke.dk> <20180427121706.23273-2-toke@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH iproute2-next v5] Add support for cake qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 16:17:05 -0000 On Fri, 27 Apr 2018 14:17:06 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > + } else if (strcmp(*argv, "datacentre") =3D=3D 0) { > + interval =3D 100; > + target =3D 5; > + } else if (strcmp(*argv, "lan") =3D=3D 0) { > + interval =3D 1000; > + target =3D 50; > + } else if (strcmp(*argv, "metro") =3D=3D 0) { > + interval =3D 10000; > + target =3D 500; > + } else if (strcmp(*argv, "regional") =3D=3D 0) { > + interval =3D 30000; > + target =3D 1500; > + } else if (strcmp(*argv, "internet") =3D=3D 0) { > + interval =3D 100000; > + target =3D 5000; > + } else if (strcmp(*argv, "oceanic") =3D=3D 0) { > + interval =3D 300000; > + target =3D 15000; > + } else if (strcmp(*argv, "satellite") =3D=3D 0) { > + interval =3D 1000000; > + target =3D 50000; > + } else if (strcmp(*argv, "interplanetary") =3D=3D 0) { > + interval =3D 1000000000; > + target =3D 50000000; > + There enough tuning entries of this type, that it would be better to make a table that can be expanded. The code should also only allow one of these options. Use duparg()?