From: David Miller <davem@davemloft.net>
To: toke@toke.dk
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
Subject: Re: [Cake] [PATCH net-next v7 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc
Date: Thu, 03 May 2018 11:24:02 -0400 (EDT) [thread overview]
Message-ID: <20180503.112402.774278226377528271.davem@davemloft.net> (raw)
In-Reply-To: <152527386316.14936.5409621935637217368.stgit@alrua-kau>
From: Toke Høiland-Jørgensen <toke@toke.dk>
Date: Wed, 02 May 2018 17:11:03 +0200
> diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c
> new file mode 100644
> index 000000000000..18bc147f12bc
> --- /dev/null
> +++ b/net/sched/sch_cake.c
> +static inline cobalt_time_t cobalt_get_time(void)
> +{
> + return ktime_get_ns();
> +}
Please do not use inline in foo.c files, let the compiler decide.
> +static inline u32
> +cake_hash(struct cake_tin_data *q, const struct sk_buff *skb, int flow_mode)
> +{
Especially for this monster! Yikes!
next prev parent reply other threads:[~2018-05-03 15:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 15:10 [Cake] [PATCH net-next v7 0/7] " Toke Høiland-Jørgensen
2018-05-02 15:11 ` [Cake] [PATCH net-next v7 1/7] " Toke Høiland-Jørgensen
2018-05-03 5:05 ` kbuild test robot
2018-05-03 5:05 ` [Cake] [PATCH] sched: fix semicolon.cocci warnings kbuild test robot
2018-05-03 15:24 ` David Miller [this message]
2018-05-03 15:28 ` [Cake] [PATCH net-next v7 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-05-02 15:11 ` [Cake] [PATCH net-next v7 2/7] sch_cake: Add ingress mode Toke Høiland-Jørgensen
2018-05-02 15:11 ` [Cake] [PATCH net-next v7 3/7] sch_cake: Add optional ACK filter Toke Høiland-Jørgensen
2018-05-03 8:26 ` kbuild test robot
2018-05-03 12:40 ` Toke Høiland-Jørgensen
2018-05-02 15:11 ` [Cake] [PATCH net-next v7 4/7] sch_cake: Add NAT awareness to packet classifier Toke Høiland-Jørgensen
2018-05-02 15:11 ` [Cake] [PATCH net-next v7 5/7] sch_cake: Add DiffServ handling Toke Høiland-Jørgensen
2018-05-02 15:11 ` [Cake] [PATCH net-next v7 6/7] sch_cake: Add overhead compensation support to the rate shaper Toke Høiland-Jørgensen
2018-05-02 15:25 ` Sebastian Moeller
2018-05-02 15:30 ` Toke Høiland-Jørgensen
2018-05-02 16:08 ` Sebastian Moeller
2018-05-02 16:15 ` Toke Høiland-Jørgensen
2018-05-02 15:11 ` [Cake] [PATCH net-next v7 7/7] sch_cake: Conditionally split GSO segments Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503.112402.774278226377528271.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cake@lists.bufferbloat.net \
--cc=netdev@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox