From: David Miller <davem@davemloft.net>
To: toke@toke.dk
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
Subject: Re: [Cake] [PATCH net-next v9 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc
Date: Sun, 13 May 2018 20:09:48 -0400 (EDT) [thread overview]
Message-ID: <20180513.200948.1658763899383204062.davem@davemloft.net> (raw)
In-Reply-To: <152579005972.4805.2514975750552805066.stgit@alrua-kau>
From: Toke Høiland-Jørgensen <toke@toke.dk>
Date: Tue, 08 May 2018 16:34:19 +0200
> +struct cake_flow {
> + /* this stuff is all needed per-flow at dequeue time */
> + struct sk_buff *head;
> + struct sk_buff *tail;
Please do not invent your own SKB list handling mechanism.
Use a standard sk_buff_head. If you don't need the locking etc., we
have interfaces like __skb_queue_head_init(), __skb_insert(), etc.
which will accomodate that.
> +static void cake_heapify(struct cake_sched_data *q, u16 i)
> +{
> + static const u32 a = CAKE_MAX_TINS * CAKE_QUEUES;
> + u32 m = i;
> + u32 mb = cake_heap_get_backlog(q, m);
Please order local variables from longest to shortest line.
The entire submissions has this problem all over the place, please
correct it patch-series wide.
Thank you.
next prev parent reply other threads:[~2018-05-14 0:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 14:34 [Cake] [PATCH net-next v9 0/7] " Toke Høiland-Jørgensen
2018-05-08 14:34 ` [Cake] [PATCH net-next v9 5/7] sch_cake: Add DiffServ handling Toke Høiland-Jørgensen
2018-05-08 14:34 ` [Cake] [PATCH net-next v9 4/7] sch_cake: Add NAT awareness to packet classifier Toke Høiland-Jørgensen
2018-05-08 14:34 ` [Cake] [PATCH net-next v9 3/7] sch_cake: Add optional ACK filter Toke Høiland-Jørgensen
2018-05-08 14:34 ` [Cake] [PATCH net-next v9 6/7] sch_cake: Add overhead compensation support to the rate shaper Toke Høiland-Jørgensen
2018-05-08 14:34 ` [Cake] [PATCH net-next v9 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-05-14 0:09 ` David Miller [this message]
2018-05-14 9:08 ` Toke Høiland-Jørgensen
2018-05-14 15:05 ` David Miller
2018-05-14 18:31 ` Toke Høiland-Jørgensen
2018-05-08 14:34 ` [Cake] [PATCH net-next v9 2/7] sch_cake: Add ingress mode Toke Høiland-Jørgensen
2018-05-08 14:59 ` Sebastian Moeller
2018-05-08 14:34 ` [Cake] [PATCH net-next v9 7/7] sch_cake: Conditionally split GSO segments Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180513.200948.1658763899383204062.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cake@lists.bufferbloat.net \
--cc=netdev@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox