From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <davem@davemloft.net>
Received: from shards.monkeyblade.net (shards.monkeyblade.net
 [184.105.139.130])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 7671F3CB37
 for <cake@lists.bufferbloat.net>; Wed, 16 May 2018 14:02:07 -0400 (EDT)
Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66])
 (using TLSv1 with cipher AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 (Authenticated sender: davem-davemloft)
 by shards.monkeyblade.net (Postfix) with ESMTPSA id 3795F13FDEC76;
 Wed, 16 May 2018 11:02:06 -0700 (PDT)
Date: Wed, 16 May 2018 14:02:03 -0400 (EDT)
Message-Id: <20180516.140203.2185491961233997679.davem@davemloft.net>
To: toke@toke.dk
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
From: David Miller <davem@davemloft.net>
In-Reply-To: <152639716493.2525.13568513738420279599.stgit@alrua-kau>
References: <152639705919.2525.3718182212727523960.stgit@alrua-kau>
 <152639716493.2525.13568513738420279599.stgit@alrua-kau>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12
 (shards.monkeyblade.net [149.20.54.216]);
 Wed, 16 May 2018 11:02:06 -0700 (PDT)
Subject: Re: [Cake] [PATCH net-next v11 1/7] sched: Add Common Applications
 Kept Enhanced (cake) qdisc
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Wed, 16 May 2018 18:02:07 -0000

From: Toke H=F8iland-J=F8rgensen <toke@toke.dk>
Date: Tue, 15 May 2018 17:12:44 +0200

> +typedef u64 cobalt_time_t;
> +typedef s64 cobalt_tdiff_t;
 ...
> +static cobalt_time_t cobalt_get_time(void)
> +{
> +	return ktime_get_ns();
> +}
> +
> +static u32 cobalt_time_to_us(cobalt_time_t val)
> +{
> +	do_div(val, NSEC_PER_USEC);
> +	return (u32)val;
> +}

If fundamentally you are working with ktime_t values, please use that t=
ype
and the associated helpers.

This is a valid argument that using custom typedefs provide documentati=
on
and an aid to understanding, but I think it doesn't serve that purpose
very well here.

So please just use ktime_t throughout instead of this cobalt_time_t
and cobalt_tdiff_t.  And then use helpers like ktime_to_us() which
properly optimize for 64-bit vs. 32-bit hosts.

Thank you.