From: David Miller <davem@davemloft.net>
To: toke@toke.dk
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net,
netfilter-devel@vger.kernel.org
Subject: Re: [Cake] [PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier
Date: Wed, 23 May 2018 16:41:52 -0400 (EDT) [thread overview]
Message-ID: <20180523.164152.387997944739062215.davem@davemloft.net> (raw)
In-Reply-To: <87in7exg3d.fsf@toke.dk>
From: Toke Høiland-Jørgensen <toke@toke.dk>
Date: Wed, 23 May 2018 22:38:30 +0200
> How would this work?
On egress the core networking flow dissector records what you need
somewhere in SKB or wherever. You later retrieve it at egress time
after NAT has occurred.
> It's about making sure the per-host fairness works when NATing, so
> we can distribute bandwidth between the hosts on the local LAN
> regardless of how many flows they open.
Ok, understood.
> But it's not unreasonable to expect people who do NAT in eBPF to
> also set skb->tc_classid if they want pre-nat host fairness, is it?
And core networking can do it as well.
Please remove this conntrack dependency, I don't think it is necessary
and it is very short sighted.
next prev parent reply other threads:[~2018-05-23 20:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 13:57 [Cake] [PATCH net-next v15 0/7] sched: Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-05-22 13:57 ` [Cake] [PATCH net-next v15 6/7] sch_cake: Add overhead compensation support to the rate shaper Toke Høiland-Jørgensen
2018-05-22 13:57 ` [Cake] [PATCH net-next v15 5/7] sch_cake: Add DiffServ handling Toke Høiland-Jørgensen
2018-05-22 13:57 ` [Cake] [PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier Toke Høiland-Jørgensen
2018-05-22 14:07 ` Pablo Neira Ayuso
2018-05-22 14:11 ` Toke Høiland-Jørgensen
2018-05-23 22:46 ` Pablo Neira Ayuso
2018-05-23 23:25 ` Toke Høiland-Jørgensen
2018-05-23 18:44 ` David Miller
2018-05-23 19:31 ` Jonathan Morton
2018-05-23 20:04 ` David Miller
2018-05-23 20:33 ` Jonathan Morton
2018-05-23 20:39 ` David Miller
2018-05-23 20:38 ` Toke Høiland-Jørgensen
2018-05-23 20:41 ` David Miller [this message]
2018-05-23 21:05 ` Toke Høiland-Jørgensen
2018-05-23 21:20 ` David Miller
2018-05-23 22:40 ` Toke Høiland-Jørgensen
2018-05-24 4:52 ` Kevin Darbyshire-Bryant
2018-05-22 13:57 ` [Cake] [PATCH net-next v15 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-05-22 13:57 ` [Cake] [PATCH net-next v15 3/7] sch_cake: Add optional ACK filter Toke Høiland-Jørgensen
2018-05-22 13:57 ` [Cake] [PATCH net-next v15 7/7] sch_cake: Conditionally split GSO segments Toke Høiland-Jørgensen
2018-05-22 13:57 ` [Cake] [PATCH net-next v15 2/7] sch_cake: Add ingress mode Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523.164152.387997944739062215.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cake@lists.bufferbloat.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox