From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net (shards.monkeyblade.net [184.105.139.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id B5A493B29E for ; Wed, 23 May 2018 16:41:55 -0400 (EDT) Received: from localhost (pool-173-77-163-54.nycmny.fios.verizon.net [173.77.163.54]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E467B144E93BE; Wed, 23 May 2018 13:41:53 -0700 (PDT) Date: Wed, 23 May 2018 16:41:52 -0400 (EDT) Message-Id: <20180523.164152.387997944739062215.davem@davemloft.net> To: toke@toke.dk Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net, netfilter-devel@vger.kernel.org From: David Miller In-Reply-To: <87in7exg3d.fsf@toke.dk> References: <152699745846.21931.4558451708304709296.stgit@alrua-kau> <20180523.144442.864194409238516747.davem@davemloft.net> <87in7exg3d.fsf@toke.dk> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 23 May 2018 13:41:54 -0700 (PDT) Subject: Re: [Cake] [PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 20:41:55 -0000 From: Toke H=F8iland-J=F8rgensen Date: Wed, 23 May 2018 22:38:30 +0200 > How would this work? On egress the core networking flow dissector records what you need somewhere in SKB or wherever. You later retrieve it at egress time after NAT has occurred. > It's about making sure the per-host fairness works when NATing, so > we can distribute bandwidth between the hosts on the local LAN > regardless of how many flows they open. Ok, understood. > But it's not unreasonable to expect people who do NAT in eBPF to > also set skb->tc_classid if they want pre-nat host fairness, is it? And core networking can do it as well. Please remove this conntrack dependency, I don't think it is necessary and it is very short sighted.