From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 75A3B3BA8E for ; Wed, 11 Jul 2018 01:56:52 -0400 (EDT) Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1887F146E9D34; Tue, 10 Jul 2018 22:56:51 -0700 (PDT) Date: Tue, 10 Jul 2018 22:56:48 -0700 (PDT) Message-Id: <20180710.225648.251006161729517659.davem@davemloft.net> To: toke@toke.dk Cc: netdev@vger.kernel.org, gamanakis@gmail.com, peteheist@gmail.com, ycheng@google.com, ncardwell@google.com, dave.taht@gmail.com, netfilter-devel@vger.kernel.org, cake@lists.bufferbloat.net From: David Miller In-Reply-To: <153089141290.14813.1010951705929696896.stgit@alrua-x1> References: <153089141290.14813.1010951705929696896.stgit@alrua-x1> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 10 Jul 2018 22:56:51 -0700 (PDT) Subject: Re: [Cake] [PATCH net-next v19 0/8] sched: Add Common Applications Kept Enhanced (cake) qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2018 05:56:52 -0000 From: Toke H=F8iland-J=F8rgensen Date: Fri, 06 Jul 2018 17:37:19 +0200 > This patch series adds the CAKE qdisc, and has been split up to ease > review. > = > I have attempted to split out each configurable feature into its own = patch. > The first commit adds the base shaper and packet scheduler, while > subsequent commits add the optional features. The full userspace API = and > most data structures are included in this commit, but options not > understood in the base version will be ignored. > = > The result of applying the entire series is identical to the out of t= ree > version that have seen extensive testing in previous deployments, mos= t > notably as an out of tree patch to OpenWrt. However, note that I have= only > compile tested the individual patches; so the whole series should be > considered as a unit. Ok, I decided to apply this even though there are still bits I'm not %100 happy with. I don't like the netfilter dependency at all. You can get the NAT addresses in other ways as I've tried to suggest in the past. Your scheme absolutely does not work with act_nat in the packet scheduler, not any NAT done by XDP/eBPF programs.