From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <davem@davemloft.net>
Received: from shards.monkeyblade.net (shards.monkeyblade.net
 [IPv6:2620:137:e000::1:9])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id EF5E23BA8E
 for <cake@lists.bufferbloat.net>; Mon, 16 Jul 2018 17:48:17 -0400 (EDT)
Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net
 [74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 (Authenticated sender: davem-davemloft)
 by shards.monkeyblade.net (Postfix) with ESMTPSA id AC45D1400A89E;
 Mon, 16 Jul 2018 14:48:16 -0700 (PDT)
Date: Mon, 16 Jul 2018 14:48:16 -0700 (PDT)
Message-Id: <20180716.144816.922973459930323763.davem@davemloft.net>
To: toke@toke.dk
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180716144509.31121-1-toke@toke.dk>
References: <20180716144509.31121-1-toke@toke.dk>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12
 (shards.monkeyblade.net [149.20.54.216]);
 Mon, 16 Jul 2018 14:48:16 -0700 (PDT)
Subject: Re: [Cake] [PATCH net-next] sch_cake: Fix tin order when set
 through skb->priority
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Mon, 16 Jul 2018 21:48:18 -0000

From: Toke H=F8iland-J=F8rgensen <toke@toke.dk>
Date: Mon, 16 Jul 2018 16:45:09 +0200

> In diffserv mode, CAKE stores tins in a different order internally th=
an
> the logical order exposed to userspace. The order remapping was missi=
ng
> in the handling of 'tc filter' priority mappings through skb->priorit=
y,
> resulting in bulk and best effort mappings being reversed relative to=

> how they are displayed.
> =

> Fix this by adding the missing mapping when reading skb->priority.
> =

> Fixes: 83f8fd69af4f ("sch_cake: Add DiffServ handling")
> Signed-off-by: Toke H=F8iland-J=F8rgensen <toke@toke.dk>

Applied, thanks.