From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pl0-x243.google.com (mail-pl0-x243.google.com
 [IPv6:2607:f8b0:400e:c01::243])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id BFB033BA8E
 for <cake@lists.bufferbloat.net>; Mon, 16 Jul 2018 13:06:49 -0400 (EDT)
Received: by mail-pl0-x243.google.com with SMTP id e11-v6so2569551plb.3
 for <cake@lists.bufferbloat.net>; Mon, 16 Jul 2018 10:06:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=c/Bm6qGzhQN9gDU/eiwA6M12OSn4dEhIPJB3lBb+rGc=;
 b=kY6HbY13/fCRnGw9q7kSFBd8VZUGYR3DNYV2cjh3Kf4QEViw/5OMMfYm/tzRSO9WCd
 kJXlvFPnauxeCp5GIOifhGUOH0RCjh6R4cjZODYt+6uyeYmXmsUiHLUc9k53i6/aZ0IX
 tvTsuFVY+xpd5DEGX/yLHG083cLEIo5o9EDKi81fidvEs1ktB5HOn5ra+BwojsSK1KFd
 DohTKJLHDisafPUq2E1AGlmUm4mkHBYmDBc2rAZ5aFIc2d0xBPYEusvEwPyngJVLbueL
 ODbIYnzm4XJLv0oZWX3GOMxEzLq8znXD/GRbQBfja9bQpqoiT/TkKQHOFm6Py+mNiP4O
 xMUQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=c/Bm6qGzhQN9gDU/eiwA6M12OSn4dEhIPJB3lBb+rGc=;
 b=WU92bMgS2C05Qytb2WpZMTe/lpH1ywdoodjar7z1qTeRMb9890+iX0B6RCoRKrZ2JW
 rRE+i7oWIV+cx8MQJUATVPCllgoLpb/tF6c3Nzc7fIJaceCh83oJ/JLiSW9v4APRahYy
 2Zt0aO5V+UTcz3aHChYlZYz+orJf83+tGaFdbqFmNRdX4+vg5Im3zW6OfFNlRzNHylC7
 QzMN2t5Hwr1EE1UHjpDCR6clpKciMGhTDWJfvC8Ejd5VgqDf1CL1lHddL0QGFkQ5poLj
 oHhmGO7Uqgyphkk6SqlCF1ZYit4+bu/zNcyo/kA4J14+U6d+IS8b71JZyE6DXCeTw92V
 3rNQ==
X-Gm-Message-State: AOUpUlGhsIqRW3dF22IEJJl5BP9uKC1OIA77Sr18KCs0tUK25ADhVJyZ
 YO6IznzN+PUZm9TZod9jhVB36w==
X-Google-Smtp-Source: AAOMgpd4Ems/T26sRAtoaZ1soqz0l8fIv10UNwEKnn9xHrqTNY7e7SZFgxCMJcJ1gsKViBLrldpgvw==
X-Received: by 2002:a17:902:aa87:: with SMTP id
 d7-v6mr17320378plr.215.1531760808862; 
 Mon, 16 Jul 2018 10:06:48 -0700 (PDT)
Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id b23-v6sm33243978pfc.49.2018.07.16.10.06.48
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Mon, 16 Jul 2018 10:06:48 -0700 (PDT)
Date: Mon, 16 Jul 2018 10:06:46 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= <toke@toke.dk>
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
Message-ID: <20180716100646.788fc9c0@xeon-e3>
In-Reply-To: <20180716163926.4826-1-toke@toke.dk>
References: <20180716163926.4826-1-toke@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Mon, 16 Jul 2018 17:06:50 -0000

On Mon, 16 Jul 2018 18:39:26 +0200
Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> wrote:

> +#define PRINT_TSTAT(name, attr, fmts, val)	do {		\
> +			if (GET_TSTAT(0, attr)) {		\
> +				fprintf(f, name);		\
> +				for (i =3D 0; i < num_tins; i++)	\
> +					fprintf(f, " %12" fmts,	val);	\
> +				fprintf(f, "\n");			\
> +			}						\
> +		} while (0)

Couldn't this be a function?