From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: dsahern@gmail.com
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net,
"Toke Høiland-Jørgensen" <toke@toke.dk>
Subject: [Cake] [PATCH iproute2-next] q_cake: Rename autorate_ingress parameter to use dash as word separator
Date: Thu, 19 Jul 2018 18:55:29 +0200 [thread overview]
Message-ID: <20180719165529.6976-1-toke@toke.dk> (raw)
This is consistent with the other multi-word parameters. Also change the
JSON output to be consistent with way it is formatted for the other
options.
Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
---
man/man8/tc-cake.8 | 4 ++--
tc/q_cake.c | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/man/man8/tc-cake.8 b/man/man8/tc-cake.8
index 0ffef094..0e84bc6e 100644
--- a/man/man8/tc-cake.8
+++ b/man/man8/tc-cake.8
@@ -9,7 +9,7 @@ CAKE \- Common Applications Kept Enhanced (CAKE)
RATE |
.BR unlimited*
|
-.BR autorate_ingress
+.BR autorate-ingress
]
.br
[
@@ -149,7 +149,7 @@ RATE
.BR tc(8)
or examples below for details of the RATE value.
.PP
-.B autorate_ingress
+.B autorate-ingress
.br
Automatic capacity estimation based on traffic arriving at this qdisc.
This is most likely to be useful with cellular links, which tend to change
diff --git a/tc/q_cake.c b/tc/q_cake.c
index b5476584..f1e232a6 100644
--- a/tc/q_cake.c
+++ b/tc/q_cake.c
@@ -71,7 +71,7 @@ static struct cake_preset *find_preset(char *argv)
static void explain(void)
{
fprintf(stderr,
-"Usage: ... cake [ bandwidth RATE | unlimited* | autorate_ingress ]\n"
+"Usage: ... cake [ bandwidth RATE | unlimited* | autorate-ingress ]\n"
" [ rtt TIME | datacentre | lan | metro | regional |\n"
" internet* | oceanic | satellite | interplanetary ]\n"
" [ besteffort | diffserv8 | diffserv4 | diffserv3* ]\n"
@@ -122,7 +122,7 @@ static int cake_parse_opt(struct qdisc_util *qu, int argc, char **argv,
bandwidth = 0;
unlimited = 1;
autorate = 0;
- } else if (strcmp(*argv, "autorate_ingress") == 0) {
+ } else if (strcmp(*argv, "autorate-ingress") == 0) {
autorate = 1;
} else if (strcmp(*argv, "rtt") == 0) {
NEXT_ARG();
@@ -435,8 +435,8 @@ static int cake_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt)
RTA_PAYLOAD(tb[TCA_CAKE_AUTORATE]) >= sizeof(__u32)) {
autorate = rta_getattr_u32(tb[TCA_CAKE_AUTORATE]);
if (autorate == 1)
- print_string(PRINT_ANY, "autorate", "autorate_%s ",
- "ingress");
+ print_string(PRINT_ANY, "autorate", "%s ",
+ "autorate-ingress");
else if (autorate)
print_string(PRINT_ANY, "autorate", "(?autorate?) ",
"unknown");
--
2.18.0
next reply other threads:[~2018-07-19 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 16:55 Toke Høiland-Jørgensen [this message]
2018-07-20 15:49 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719165529.6976-1-toke@toke.dk \
--to=toke@toke.dk \
--cc=cake@lists.bufferbloat.net \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox