From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <davem@davemloft.net>
Received: from shards.monkeyblade.net (shards.monkeyblade.net
 [IPv6:2620:137:e000::1:9])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 4FEFF3B2A4
 for <cake@lists.bufferbloat.net>; Thu, 23 Aug 2018 00:40:37 -0400 (EDT)
Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net
 [74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 (Authenticated sender: davem-davemloft)
 by shards.monkeyblade.net (Postfix) with ESMTPSA id D8014108D80AF;
 Wed, 22 Aug 2018 21:40:35 -0700 (PDT)
Date: Wed, 22 Aug 2018 21:40:35 -0700 (PDT)
Message-Id: <20180822.214035.2296047368518586541.davem@davemloft.net>
To: toke@toke.dk
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
From: David Miller <davem@davemloft.net>
In-Reply-To: <153493378299.2819.2335994387383507473.stgit@alrua-kau>
References: <153493378299.2819.2335994387383507473.stgit@alrua-kau>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12
 (shards.monkeyblade.net [149.20.54.216]);
 Wed, 22 Aug 2018 21:40:36 -0700 (PDT)
Subject: Re: [Cake] [PATCH] sch_cake: Fix TC filter flow override and expand
 it to hosts as well
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Thu, 23 Aug 2018 04:40:37 -0000

From: Toke H=F8iland-J=F8rgensen <toke@toke.dk>
Date: Wed, 22 Aug 2018 12:29:43 +0200

> The TC filter flow mapping override completely skipped the call to
> cake_hash(); however that meant that the internal state was not being=

> updated, which ultimately leads to deadlocks in some configurations. =
Fix
> that by passing the overridden flow ID into cake_hash() instead so it=
 can
> react appropriately.
> =

> In addition, the major number of the class ID can now be set to overr=
ide
> the host mapping in host isolation mode. If both host and flow are
> overridden (or if the respective modes are disabled), flow dissection=
 and
> hashing will be skipped entirely; otherwise, the hashing will be kept=
 for
> the portions that are not set by the filter.
> =

> Signed-off-by: Toke H=F8iland-J=F8rgensen <toke@toke.dk>

Applied.