Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: toke@toke.dk
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net,
	edumazet@google.com, dave.taht@gmail.com
Subject: Re: [Cake] [PATCH net v2] gso_segment: Reset skb->mac_len after modifying network header
Date: Thu, 13 Sep 2018 12:10:29 -0700 (PDT)	[thread overview]
Message-ID: <20180913.121029.1793900247036084325.davem@davemloft.net> (raw)
In-Reply-To: <20180913144306.9077-1-toke@toke.dk>

From: Toke Høiland-Jørgensen <toke@toke.dk>
Date: Thu, 13 Sep 2018 16:43:07 +0200

> When splitting a GSO segment that consists of encapsulated packets, the
> skb->mac_len of the segments can end up being set wrong, causing packet
> drops in particular when using act_mirred and ifb interfaces in
> combination with a qdisc that splits GSO packets.
> 
> This happens because at the time skb_segment() is called, network_header
> will point to the inner header, throwing off the calculation in
> skb_reset_mac_len(). The network_header is subsequently adjust by the
> outer IP gso_segment handlers, but they don't set the mac_len.
> 
> Fix this by adding skb_reset_mac_len() calls to both the IPv4 and IPv6
> gso_segment handlers, after they modify the network_header.
> 
> Many thanks to Eric Dumazet for his help in identifying the cause of
> the bug.
> 
> Acked-by: Dave Taht <dave.taht@gmail.com>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
> ---
> v2:
>   - Properly credit Eric for his help
>   - Add review and ack tags

Applied and queued up for -stable, thanks.

      reply	other threads:[~2018-09-13 19:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-11 22:19 [Cake] [PATCH net] " Toke Høiland-Jørgensen
2018-09-13 14:11 ` Eric Dumazet
2018-09-13 14:14   ` Dave Taht
2018-09-13 14:22   ` Toke Høiland-Jørgensen
2018-09-13 14:43 ` [Cake] [PATCH net v2] " Toke Høiland-Jørgensen
2018-09-13 19:10   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180913.121029.1793900247036084325.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=cake@lists.bufferbloat.net \
    --cc=dave.taht@gmail.com \
    --cc=edumazet@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox