Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: toke@redhat.com
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net, fuller@beif.de
Subject: Re: [Cake] [PATCH net] sch_cake: Interpret fwmark parameter as a bitmask
Date: Fri, 15 Mar 2019 11:57:38 -0700 (PDT)	[thread overview]
Message-ID: <20190315.115738.147858309937637.davem@davemloft.net> (raw)
In-Reply-To: <20190314220822.19704-1-toke@redhat.com>

From: Toke Høiland-Jørgensen <toke@redhat.com>
Date: Thu, 14 Mar 2019 23:08:22 +0100

> We initially interpreted the fwmark parameter as a flag that simply turned
> on the feature, using the whole skb->mark field as the index into the CAKE
> tin_order array. However, it is quite common for different applications to
> use different parts of the mask field for their own purposes, each using a
> different mask.
> 
> Support this use of subsets of the mark by interpreting the TCA_CAKE_FWMARK
> parameter as a bitmask to apply to the fwmark field when reading it. The
> result will be right-shifted by the number of unset lower bits of the mask
> before looking up the tin.
> 
> In the original commit message we also failed to credit Felix Resch with
> originally suggesting the fwmark feature back in 2017; so the Suggested-By
> in this commit covers the whole fwmark feature.
> 
> Fixes: 0b5c7efdfc6e ("sch_cake: Permit use of connmarks as tin classifiers")
> Suggested-by: Felix Resch <fuller@beif.de>
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>

You are lucky you decided to do this before a released kernel had this UAPI
available.

Applied.

  reply	other threads:[~2019-03-15 18:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-14 22:08 Toke Høiland-Jørgensen
2019-03-15 18:57 ` David Miller [this message]
2019-03-15 21:29   ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190315.115738.147858309937637.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=cake@lists.bufferbloat.net \
    --cc=fuller@beif.de \
    --cc=netdev@vger.kernel.org \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox