From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 09FE73B29E for ; Thu, 4 Apr 2019 15:35:39 -0400 (EDT) Received: by mail-pf1-x443.google.com with SMTP id 188so1853187pfd.8 for ; Thu, 04 Apr 2019 12:35:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hpFyYSegsR0ReYOZ5mEGU7Z/lco1FGO4TDqU96iOI2g=; b=yc3RYnGXt44676sFbXZY2mNHNWUHSb0nhZe0YXwjCVzglCqzC4s75N8Kt53euQwLcm 24z21MJ+NMdCsaFlPPSjoVRB6jMmNrZddGf2h7+03cTFx1vNUE7HGyi6pGSONuh8fRPc toHS+dPStjG9zOhMgkal0b97eyvaIhZf+/zI83dqHGMzrk3952RcHwH6IMP/8kabc2JR k0oAhwPYd5UchC5xRaGXFxsRt4Zf8y4HKhKDzW7VWHQ725MnZecLyH9pDpyDhcXKYy58 I7Qm2ZzHQz6Bxx1CT4XyMz+rDO98OSEo9Z+2ynoP7M6WTVFf11Ivuor7uKsDHpIGJG2Y 0Pow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hpFyYSegsR0ReYOZ5mEGU7Z/lco1FGO4TDqU96iOI2g=; b=ZW8Hm+otNU58hao0Ub9JhTvTLrRmpo6IfAK0SGBpJihI7QGlzLqo9tJhdY2ru5mfjC 8WMEtzFTLjFmEMddc9YCQXQI3N/LnnZHBozipD00BKuCGnVFw7/swEPcK8iLxl2mobOU g3JK4hFc+xV1NA3BMvXDovICzw17Mpll9Hy3daqYdFJ1H48xe2ACWoCbf/vwk0ly6gfS dnAqcouggRUWO5Wb5c+MUyxNnZTTlBimen+8hdfj1VR0iXhI6DQmDz74N+Gbq72i5b3R YfJi7j8jkWbtJyqP3fHI6tWE6dsWS+ybq13XtB5GoQ+qJkseEQAPhNwrThlnLSoPURAz QuRw== X-Gm-Message-State: APjAAAWxdiqmGK+apRz5EoGEPTshJ22h+ox+gFZdAzCSeJZBs4DHH5fb 9nyWNsX/fVrM7LEKUaBPotBXaA== X-Google-Smtp-Source: APXvYqxRVw6Ip7u0rijudliyWTHuW0SPLuqpfIYNUD1VyR33u75AgviHx2vDiLq//tYTi8W0t5HD7Q== X-Received: by 2002:a63:cc0d:: with SMTP id x13mr7837233pgf.280.1554406538877; Thu, 04 Apr 2019 12:35:38 -0700 (PDT) Received: from shemminger-XPS-13-9360 ([167.220.60.23]) by smtp.gmail.com with ESMTPSA id y37sm30094975pgk.78.2019.04.04.12.35.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Apr 2019 12:35:38 -0700 (PDT) Date: Thu, 4 Apr 2019 12:35:36 -0700 From: Stephen Hemminger To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: David Miller , netdev@vger.kernel.org, cake@lists.bufferbloat.net Message-ID: <20190404123536.3c966937@shemminger-XPS-13-9360> In-Reply-To: <155438289374.18760.4278774647362746152.stgit@alrua-x1> References: <155438289359.18760.18027832614176337074.stgit@alrua-x1> <155438289374.18760.4278774647362746152.stgit@alrua-x1> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH net 2/2] sch_cake: Make sure we can write the IP header before changing DSCP bits X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Apr 2019 19:35:40 -0000 On Thu, 04 Apr 2019 15:01:33 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > static u8 cake_handle_diffserv(struct sk_buff *skb, u16 wash) > { > + int wlen =3D skb_network_offset(skb); In theory this could be negative, you should handle that? Rather than calling may_pull() with a huge unsigned value.