From: David Miller <davem@davemloft.net>
To: wenyang@linux.alibaba.com
Cc: toke@toke.dk, ldir@darbyshire-bryant.me.uk, toke@redhat.com,
xiyou.wangcong@gmail.com, cake@lists.bufferbloat.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Cake] [PATCH] sch_cake: avoid possible divide by zero in cake_enqueue()
Date: Thu, 02 Jan 2020 16:35:07 -0800 (PST) [thread overview]
Message-ID: <20200102.163507.404343273086201773.davem@davemloft.net> (raw)
In-Reply-To: <20200102092143.8971-1-wenyang@linux.alibaba.com>
From: Wen Yang <wenyang@linux.alibaba.com>
Date: Thu, 2 Jan 2020 17:21:43 +0800
> The variables 'window_interval' is u64 and do_div()
> truncates it to 32 bits, which means it can test
> non-zero and be truncated to zero for division.
> The unit of window_interval is nanoseconds,
> so its lower 32-bit is relatively easy to exceed.
> Fix this issue by using div64_u64() instead.
>
> Fixes: 7298de9cd725 ("sch_cake: Add ingress mode")
> Signed-off-by: Wen Yang <wenyang@linux.alibaba.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2020-01-03 0:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 9:21 Wen Yang
2020-01-02 21:58 ` Jonathan Morton
2020-01-02 23:34 ` Toke Høiland-Jørgensen
2020-01-03 0:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200102.163507.404343273086201773.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cake@lists.bufferbloat.net \
--cc=ldir@darbyshire-bryant.me.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
--cc=toke@toke.dk \
--cc=wenyang@linux.alibaba.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox