From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id B8B453B2A4 for ; Fri, 29 May 2020 13:57:02 -0400 (EDT) Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A21002073B; Fri, 29 May 2020 17:57:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590775021; bh=6hjkRiGoDWgBwj+tfVkMty4dGqtVTTKH+mMJl6ebRw4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=m2v7LLGjYpRyy5G0GGiUhTpUqTuBYmANXmFtGltlFyf/sGZ6dJl2z3K12bO9YXh/Y F42fVWSH1RRw8row7nrZTVBMpxVj024kB6i9rZ7yciQLVFsYrwCOLLxHm0D82iLEdm +tpQ2NhK8tDq7nSHbykz14A03QmSvq3mqAg4umzA= Date: Fri, 29 May 2020 10:57:00 -0700 From: Jakub Kicinski To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: davem@davemloft.net, netdev@vger.kernel.org, cake@lists.bufferbloat.net Message-ID: <20200529105700.73a2b017@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20200529124344.355785-1-toke@redhat.com> References: <20200529124344.355785-1-toke@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Fri, 29 May 2020 14:14:45 -0400 Subject: Re: [Cake] [PATCH net] sch_cake: Take advantage of skb->hash where appropriate X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2020 17:57:02 -0000 On Fri, 29 May 2020 14:43:44 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > + * enabled there's another check below after doing the conntrack lookup. > + */ nit: alignment