From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id EF4313CB35 for ; Tue, 25 Jan 2022 01:04:22 -0500 (EST) Received: by codeconstruct.com.au (Postfix, from userid 10001) id 9C7F0202F7; Tue, 25 Jan 2022 14:04:16 +0800 (AWST) From: Matt Johnston To: Cc: Kevin Darbyshire-Bryant , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, cake@lists.bufferbloat.net Date: Tue, 25 Jan 2022 14:04:10 +0800 Message-Id: <20220125060410.2691029-1-matt@codeconstruct.com.au> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Tue, 25 Jan 2022 06:24:42 -0500 Subject: [Cake] [PATCH net] sch_cake: diffserv8 CS1 should be bulk X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jan 2022 06:04:23 -0000 The CS1 priority (index 0x08) was changed from 0 to 1 when LE (index 0x01) was added. This looks unintentional, it doesn't match the docs and CS1 shouldn't be the same tin as AF1x Signed-off-by: Matt Johnston Fixes: b8392808eb3f ("sch_cake: add RFC 8622 LE PHB support to CAKE diffserv handling") --- net/sched/sch_cake.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c index 857aaebd49f4..6ff2ddc5b812 100644 --- a/net/sched/sch_cake.c +++ b/net/sched/sch_cake.c @@ -313,7 +313,7 @@ static const u8 precedence[] = { static const u8 diffserv8[] = { 2, 0, 1, 2, 4, 2, 2, 2, - 1, 2, 1, 2, 1, 2, 1, 2, + 0, 2, 1, 2, 1, 2, 1, 2, 5, 2, 4, 2, 4, 2, 4, 2, 3, 2, 3, 2, 3, 2, 3, 2, 6, 2, 3, 2, 3, 2, 3, 2, -- 2.32.0