Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
* Re: [Cake] [PATCH 0/3] net/sched: Load modules via alias
       [not found]   ` <vk6uhf4r2turfxt2aokp66x5exzo5winal55253czkl2pmkkuu@77bhdfwfk5y3>
@ 2023-12-06 22:28     ` Stephen Hemminger
       [not found]       ` <53ohvb547tegxv2vuvurhuwqunamfiy22sonog7gll54h3czht@3dnijc44xilq>
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2023-12-06 22:28 UTC (permalink / raw)
  To: Michal Koutný
  Cc: Pedro Tammela, netdev, linux-kernel, bpf, cake, David S . Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jamal Hadi Salim,
	Cong Wang, Jiri Pirko, Alexei Starovoitov, Daniel Borkmann,
	Andrii Nakryiko, Martin KaFai Lau, Song Liu, Yonghong Song,
	John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa,
	Toke Høiland-Jørgensen, Vinicius Costa Gomes,
	Petr Pavlu, Michal Kubecek, Martin Wilck

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

On Wed, 6 Dec 2023 22:18:25 +0100
Michal Koutný <mkoutny@suse.com> wrote:

> On Wed, Dec 06, 2023 at 05:16:28PM -0300, Pedro Tammela <pctammela@mojatatu.com> wrote:
> > Can't you just keep the sch-, cls-, act- prefixes for the aliases?
> > They look odd in the current patchset TBH  
> 
> I'm open to different better naming.
> 
> Although, this natural option would clash with the behavior
> (modprobe(8)):
> 
> > there is no difference between _ and - in module names  
> 
> Thus blacklisting via an alias vs not-blacklisting via non-canonical
> name would contradict each other :-/
> 
> Michal

It is not clear to me what this patchset is trying to fix.
Autoloading happens now, but it does depend on the name not alias.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Cake] [PATCH 0/3] net/sched: Load modules via alias
       [not found]       ` <53ohvb547tegxv2vuvurhuwqunamfiy22sonog7gll54h3czht@3dnijc44xilq>
@ 2023-12-06 23:42         ` Toke Høiland-Jørgensen
  2023-12-06 23:55         ` Stephen Hemminger
  1 sibling, 0 replies; 3+ messages in thread
From: Toke Høiland-Jørgensen @ 2023-12-06 23:42 UTC (permalink / raw)
  To: Michal Koutný, Stephen Hemminger
  Cc: Pedro Tammela, netdev, linux-kernel, bpf, cake, David S . Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jamal Hadi Salim,
	Cong Wang, Jiri Pirko, Alexei Starovoitov, Daniel Borkmann,
	Andrii Nakryiko, Martin KaFai Lau, Song Liu, Yonghong Song,
	John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa,
	Vinicius Costa Gomes, Petr Pavlu, Michal Kubecek, Martin Wilck

Michal Koutný <mkoutny@suse.com> writes:

> On Wed, Dec 06, 2023 at 02:28:57PM -0800, Stephen Hemminger <stephen@networkplumber.org> wrote:
>> It is not clear to me what this patchset is trying to fix.
>> Autoloading happens now, but it does depend on the name not alias.
>
> There are some more details in the thread of v1 [1] [2].
> Does it clarify?

Yes, but this should be explained clearly in the commit message
(including the reason why this is useful, in the follow-up to [1]).

-Toke


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Cake] [PATCH 0/3] net/sched: Load modules via alias
       [not found]       ` <53ohvb547tegxv2vuvurhuwqunamfiy22sonog7gll54h3czht@3dnijc44xilq>
  2023-12-06 23:42         ` Toke Høiland-Jørgensen
@ 2023-12-06 23:55         ` Stephen Hemminger
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2023-12-06 23:55 UTC (permalink / raw)
  To: Michal Koutný
  Cc: Pedro Tammela, netdev, linux-kernel, bpf, cake, David S . Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jamal Hadi Salim,
	Cong Wang, Jiri Pirko, Alexei Starovoitov, Daniel Borkmann,
	Andrii Nakryiko, Martin KaFai Lau, Song Liu, Yonghong Song,
	John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa,
	Toke Høiland-Jørgensen, Vinicius Costa Gomes,
	Petr Pavlu, Michal Kubecek, Martin Wilck

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

On Wed, 6 Dec 2023 23:49:14 +0100
Michal Koutný <mkoutny@suse.com> wrote:

> On Wed, Dec 06, 2023 at 02:28:57PM -0800, Stephen Hemminger <stephen@networkplumber.org> wrote:
> > It is not clear to me what this patchset is trying to fix.
> > Autoloading happens now, but it does depend on the name not alias.  
> 
> There are some more details in the thread of v1 [1] [2].
> Does it clarify?
> 
> Thanks,
> Michal
> 
> [1] https://lore.kernel.org/r/yerqczxbz6qlrslkfbu6u2emb5esqe7tkrexdbneite2ah2a6i@l6arp7nzyj75/
> [2] Oh, I realize I forgot to add v2 to today's posting.
> 
> 

So your using blacklist as workaround security method and the name confuses it now.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-12-06 23:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20231206192752.18989-1-mkoutny@suse.com>
     [not found] ` <7789659d-b3c5-4eef-af86-540f970102a4@mojatatu.com>
     [not found]   ` <vk6uhf4r2turfxt2aokp66x5exzo5winal55253czkl2pmkkuu@77bhdfwfk5y3>
2023-12-06 22:28     ` [Cake] [PATCH 0/3] net/sched: Load modules via alias Stephen Hemminger
     [not found]       ` <53ohvb547tegxv2vuvurhuwqunamfiy22sonog7gll54h3czht@3dnijc44xilq>
2023-12-06 23:42         ` Toke Høiland-Jørgensen
2023-12-06 23:55         ` Stephen Hemminger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox