From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 4506E3CB37 for ; Sat, 6 Apr 2024 19:55:40 -0400 (EDT) Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-2a2bcc0c075so877580a91.0 for ; Sat, 06 Apr 2024 16:55:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712447739; x=1713052539; darn=lists.bufferbloat.net; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=AXM7kfM1Z58yWKWsC/e8tiwljIuUChOEbm514WnQ12k=; b=UysH18Dk9Mq8YT8Pd7uhy9nvhMH0NaaIU4F6bDgrJFOiGbBeKw6S/ri1uC1lOyvhHU xnEmoNiJkJLKtY0C9jgFBV85m7PB18x+DFsDYx0T/vNeByc7iS7QNYcbz8Rq2u0krioV VBn8fQahoyje2x6EUGIMgAcueTJJXXsAx0Zxlde1Q63cbsarSnTYVJFnm41tXBRolRrL odfaszpaDHKqJnIEmVM85im/nPWPI8WvCj0F/NlPjQpOjCHNMAyc9m1S6nCGz27JhPZP oi9XGr//uolTOK+Zz14evW98guto9TjFwfgS/OQCsijOVTMj4gSnf120ufGqQPyK9/fF L7hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712447739; x=1713052539; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AXM7kfM1Z58yWKWsC/e8tiwljIuUChOEbm514WnQ12k=; b=cfQWr7vw3eC939D+bJjaK0sbKpQjY5axh1zWExKpiJED6z3y89pA042cqKUv1j73fH VyNy6mRMQTgcfXflBy21oQmnVJYr4edQGypJ2ikrgS6F/xH3S5oel9IwGB72glJSYQer zFzS+g2AizKccsDB9MFjknT/Jlocy2CK2ltT9E86N53aA+PbmQdc4Rcy8De/Njm+eWTL Vtw44N1D1s47HRFTvaoWvB0JzMRszbiRLqBPsKLsTwyzDjsa7pmS5WX5VVnoVOADc3at 8DPlnypkNDtNGX/UUSZvq13kn+PYGqN76roqAAjLyqdz8qG96T1m0dz3uoIlzYzCwpHR Q2dw== X-Forwarded-Encrypted: i=1; AJvYcCWzz/0/ESAWlME/42ROeXHkxIm3np1X7qSK42YQVlW7cZM8cIwPhO7wSEovOEdoklIWb0709013ZxC94PI5e+uQxeEe/FvZMZQudA== X-Gm-Message-State: AOJu0YwbEoJTupTgspLaD8lX5gZgN1g5euVQhu8Rk/7MnCgVYgWhq6t9 xgMi2fWJiPLbXusYdN3pCKKEB04ESMnoWYP7qLQbvAg5zgSpE5dy X-Google-Smtp-Source: AGHT+IE3B5Pz+/ZkseS/mNk/yx/nQmMtrI/bGxa3Q0nv17K2q4uzMUrg6CzyBHy6NMcob3bTLeEQEQ== X-Received: by 2002:a17:90a:8996:b0:2a2:83b0:5fad with SMTP id v22-20020a17090a899600b002a283b05fadmr4669920pjn.2.1712447739216; Sat, 06 Apr 2024 16:55:39 -0700 (PDT) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id bt8-20020a17090af00800b002a2b06ce909sm5460178pjb.17.2024.04.06.16.55.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 16:55:38 -0700 (PDT) From: Kuan-Wei Chiu To: toke@toke.dk Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jserv@ccns.ncku.edu.tw, cake@lists.bufferbloat.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kuan-Wei Chiu Message-Id: <20240406235532.613696-1-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Mon, 29 Apr 2024 18:18:51 -0400 Subject: [Cake] [PATCH net-next] net: sched: cake: Optimize number of calls to cake_heapify() X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sat, 06 Apr 2024 23:55:40 -0000 X-Original-Date: Sun, 7 Apr 2024 07:55:32 +0800 X-List-Received-Date: Sat, 06 Apr 2024 23:55:40 -0000 Improve the max-heap construction process by reducing unnecessary heapify operations. Specifically, adjust the starting condition from n / 2 to n / 2 - 1 in the loop that iterates over all non-leaf elements. Signed-off-by: Kuan-Wei Chiu --- net/sched/sch_cake.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c index edee926ccde8..2eabc4dc5b79 100644 --- a/net/sched/sch_cake.c +++ b/net/sched/sch_cake.c @@ -1512,7 +1512,7 @@ static unsigned int cake_drop(struct Qdisc *sch, struct sk_buff **to_free) if (!q->overflow_timeout) { int i; /* Build fresh max-heap */ - for (i = CAKE_MAX_TINS * CAKE_QUEUES / 2; i >= 0; i--) + for (i = CAKE_MAX_TINS * CAKE_QUEUES / 2 - 1; i >= 0; i--) cake_heapify(q, i); } q->overflow_timeout = 65535; -- 2.34.1