From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kuba@kernel.org>
Received: from nyc.source.kernel.org (nyc.source.kernel.org
 [IPv6:2604:1380:45d1:ec00::3])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 7816C3CB38
 for <cake@lists.bufferbloat.net>; Mon,  9 Dec 2024 18:51:59 -0500 (EST)
Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])
 by nyc.source.kernel.org (Postfix) with ESMTP id 99203A41A50;
 Mon,  9 Dec 2024 23:50:07 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 621E9C4CED1;
 Mon,  9 Dec 2024 23:51:58 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
 s=k20201202; t=1733788318;
 bh=8UK2uET75K2Fs6UHha5BLMs94LdFMBM77wMB7p8SbBc=;
 h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
 b=kmm9C9ulVYoNl+FBTgLFJd/8mc1weOh0F6XavqRiKDzHPYFBHYYZzF/tu9Weo5Hrn
 HjqlZ+3cAgmeqwOu3qvIQsTxmHjD5P8a0VUM02yYzauYSuHSOMS8GLWYfCe8V7Shjk
 o3Gh7gS0vzVrGfdt3b3Eedbuu8vfTap0EnZS/ts7+pZmL40DZ9SB6LCOkcYec/J0pK
 eRhgKCssjmEDDF3UIHBhJJMVPajAlMVxtvE4kuuAXH5vJ1/n3xTgbvFObv2Y2sHbHk
 g94ZS4ToS+An3qX4SlCdUDsYcOTwuA07CkXh0M9BAuoYgQrUIs60D2+wC5GdzCHGGG
 AIpql8ewnyVmg==
Date: Mon, 9 Dec 2024 15:51:57 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= <toke@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>, Simon Horman
 <horms@kernel.org>, Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?=
 <toke@toke.dk>, Jamal Hadi Salim <jhs@mojatatu.com>, Cong Wang
 <xiyou.wangcong@gmail.com>, Jiri Pirko <jiri@resnulli.us>,
 netdev@vger.kernel.org, cake@lists.bufferbloat.net
Message-ID: <20241209155157.6a817bc5@kernel.org>
In-Reply-To: <20241209-cake-drop-reason-v1-1-19205f6d1f19@redhat.com>
References: <20241209-cake-drop-reason-v1-1-19205f6d1f19@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Cake] [PATCH net-next] net_sched: sch_cake: Add drop reasons
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Mon, 09 Dec 2024 23:51:59 -0000

On Mon, 09 Dec 2024 13:02:18 +0100 Toke H=C3=B8iland-J=C3=B8rgensen wrote:
> Add three qdisc-specific drop reasons for sch_cake:
>=20
>  1) SKB_DROP_REASON_CAKE_CONGESTED
>     Whenever a packet is dropped by the CAKE AQM algorithm because
>     congestion is detected.
>=20
>  2) SKB_DROP_REASON_CAKE_FLOOD
>     Whenever a packet is dropped by the flood protection part of the
>     CAKE AQM algorithm (BLUE).
>=20
>  3) SKB_DROP_REASON_CAKE_OVERLIMIT
>     Whenever the total queue limit for a CAKE instance is exceeded and a
>     packet is dropped to make room.

Eric's patch was adding fairly FQ-specific reasons, other than flood
this seems like generic AQM stuff, no? From a very quick look the
congestion looks like fairly standard AQM, overlimit is also typical
for qdics?