From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 43F173CB37 for ; Wed, 11 Dec 2024 13:54:52 -0500 (EST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id BB9A1A41828; Wed, 11 Dec 2024 18:53:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25F34C4CED4; Wed, 11 Dec 2024 18:54:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733943291; bh=3VYmXnMI4su6R0mhdY7vsuCOVCVssqNMN6WEYch34QE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gCnVLuhveQjxh+uFtEF2FjfHjMlIRh3SrCyC+DZ5D2mwBWmgwE9kT3WiLRNERsl84 VX/thGEW6FxgYdPVVguMTKPTiO420xhAByc8l2C9nS5ivJ4ELVcDWMYrwq3i93YDiN 4/+XJ29BNPHWVRpi+z9DjJGkq/xogJ6zQcr+fm5/AFqsZ7qH/5K0mjx6oUKobYpLky jDw8BSnNIpZzLSyqvh35dxsa3bdOdvn0kLkyD89DrMJKDq3102gwDD7L9/PzylM58H wPHKSXUzTq9RsWVCgSbG8jI97CBi5KotZJAz7tidnM63dDyqz9Z14Zs3mf79shvlPO 6m/5Nad7emUAw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Lion Ackermann , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , "David S . Miller" , Sasha Levin , jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, cake@lists.bufferbloat.net, netdev@vger.kernel.org Message-ID: <20241211185442.3843374-5-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241211185442.3843374-1-sashal@kernel.org> References: <20241211185442.3843374-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.286 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Sat, 28 Dec 2024 08:25:46 -0500 Subject: [Cake] [PATCH AUTOSEL 5.4 5/7] net: sched: fix ordering of qlen adjustment X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Wed, 11 Dec 2024 18:54:52 -0000 X-Original-Date: Wed, 11 Dec 2024 13:54:38 -0500 X-List-Received-Date: Wed, 11 Dec 2024 18:54:52 -0000 From: Lion Ackermann [ Upstream commit 5eb7de8cd58e73851cd37ff8d0666517d9926948 ] Changes to sch->q.qlen around qdisc_tree_reduce_backlog() need to happen _before_ a call to said function because otherwise it may fail to notify parent qdiscs when the child is about to become empty. Signed-off-by: Lion Ackermann Acked-by: Toke Høiland-Jørgensen Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/sched/sch_cake.c | 2 +- net/sched/sch_choke.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c index 9b4a9bdbeafd9..f2a49bccb5ef5 100644 --- a/net/sched/sch_cake.c +++ b/net/sched/sch_cake.c @@ -1505,7 +1505,6 @@ static unsigned int cake_drop(struct Qdisc *sch, struct sk_buff **to_free) b->backlogs[idx] -= len; b->tin_backlog -= len; sch->qstats.backlog -= len; - qdisc_tree_reduce_backlog(sch, 1, len); flow->dropped++; b->tin_dropped++; @@ -1516,6 +1515,7 @@ static unsigned int cake_drop(struct Qdisc *sch, struct sk_buff **to_free) __qdisc_drop(skb, to_free); sch->q.qlen--; + qdisc_tree_reduce_backlog(sch, 1, len); cake_heapify(q, 0); diff --git a/net/sched/sch_choke.c b/net/sched/sch_choke.c index e54f6eabfa0c0..2007bc4f96709 100644 --- a/net/sched/sch_choke.c +++ b/net/sched/sch_choke.c @@ -124,10 +124,10 @@ static void choke_drop_by_idx(struct Qdisc *sch, unsigned int idx, if (idx == q->tail) choke_zap_tail_holes(q); + --sch->q.qlen; qdisc_qstats_backlog_dec(sch, skb); qdisc_tree_reduce_backlog(sch, 1, qdisc_pkt_len(skb)); qdisc_drop(skb, sch, to_free); - --sch->q.qlen; } struct choke_skb_cb { -- 2.43.0