From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 9D7523B2A4 for ; Thu, 9 Jan 2025 11:18:13 -0500 (EST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 822B5A420EB; Thu, 9 Jan 2025 16:16:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46624C4CED2; Thu, 9 Jan 2025 16:18:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736439492; bh=10+Dg1BFv4IwT+mfDUUg++YF0ACEY5Xdn5RCQC9n7x0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VaD9up5GXA9v64/lMaOzJOYE+w682V2ZN2vhCVKLEFMj1e52pi2ajwdscruac9aHJ /Lq1J97TCBId3IHrg6edXUay0E99IqfaqYRMUscyTUgBiS84Qp6YvMXCRtv6A6ftTz SwIeUuZlzrVHZnI46XXysBWetiK+lumkfl3OAFjvLpYyo9MKkpcv0UHxaU2AMgrjJD AtNZAonmkAwWVQHcyevyJujOXojhCLjX/ih0EEtEgOiVMopo3DXj+b2dI9Qk3zgMft Dg9lpONgtxabJWkFdebvAxsFzaLgGiE5uDTzSpavPVgUYpZ1CM0uGqjbm3SB9Hb/ht 16S0GXizoZv6w== Date: Thu, 9 Jan 2025 08:18:11 -0800 From: Jakub Kicinski To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: Paolo Abeni , Jamal Hadi Salim , Cong Wang , Jiri Pirko , syzbot+f63600d288bfb7057424@syzkaller.appspotmail.com, "David S. Miller" , Eric Dumazet , Simon Horman , cake@lists.bufferbloat.net, netdev@vger.kernel.org Message-ID: <20250109081811.01b7bad1@kernel.org> In-Reply-To: <87ikqohswh.fsf@toke.dk> References: <20250107120105.70685-1-toke@redhat.com> <87plkwi27e.fsf@toke.dk> <11915c70-ec5e-4d94-b890-f07f41094e2c@redhat.com> <87ikqohswh.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH net v2] sched: sch_cake: add bounds checks to host bulk flow fairness counts X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jan 2025 16:18:13 -0000 On Thu, 09 Jan 2025 17:08:14 +0100 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > >> I guess I should have mentioned in the commit message that this was > >> deliberate. Since it seems you'll be editing that anyway (cf the above= ), > >> how about adding a paragraph like: > >>=20 > >> As part of this change, the flow quantum calculation is consolidated > >> into a helper function, which means that the dithering applied to the > >> host load scaling is now applied both in the DRR rotation and when a > >> sparse flow's quantum is first initiated. The only user-visible effect > >> of this is that the maximum packet size that can be sent while a flow > >> stays sparse will now vary with +/- one byte in some cases. This shou= ld > >> not make a noticeable difference in practice, and thus it's not worth > >> complicating the code to preserve the old behaviour. =20 > > > > It's in Jakub's hands now, possibly he could prefer a repost to reduce > > the maintainer's overhead. =20 >=20 > Alright, sure, I'll respin :) Hold on, I'll do it :)