From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"Cong Wang" <xiyou.wangcong@gmail.com>,
"Jiri Pirko" <jiri@resnulli.us>
Cc: "Dave Taht" <dave.taht@gmail.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
cake@lists.bufferbloat.net, netdev@vger.kernel.org
Subject: [Cake] [PATCH net-next] sched: sch_cake: Align QoS treatment to Windows and Zoom
Date: Fri, 10 Jan 2025 16:55:30 +0100 [thread overview]
Message-ID: <20250110155531.300303-1-toke@redhat.com> (raw)
From: Dave Taht <dave.taht@gmail.com>
Cake's diffserv4 mode attempted to follow the IETF webrtc
QoS marking standards, RFC8837.
It turns out Windows QoS can only use CS0, CS1, CS5, and CS7.
Zoom defaults to using CS5 for video and screen sharing traffic.
Bump CS4, CS5, and NQB to the video tin (2) in diffserv4 mode, for
more bandwidth and lower priority.
This also better aligns with how WiFi presently treats CS5 and NQB.
Signed-off-by: Dave Taht <dave.taht@gmail.com>
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
---
net/sched/sch_cake.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c
index 48dd8c88903f..2a9288d4b873 100644
--- a/net/sched/sch_cake.c
+++ b/net/sched/sch_cake.c
@@ -328,8 +328,8 @@ static const u8 diffserv4[] = {
1, 0, 0, 0, 0, 0, 0, 0,
2, 0, 2, 0, 2, 0, 2, 0,
2, 0, 2, 0, 2, 0, 2, 0,
- 3, 0, 2, 0, 2, 0, 2, 0,
- 3, 0, 0, 0, 3, 0, 3, 0,
+ 2, 0, 2, 0, 2, 0, 2, 0,
+ 2, 0, 0, 0, 2, 0, 3, 0,
3, 0, 0, 0, 0, 0, 0, 0,
3, 0, 0, 0, 0, 0, 0, 0,
};
--
2.47.1
next reply other threads:[~2025-01-10 15:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 15:55 Toke Høiland-Jørgensen [this message]
2025-01-10 16:24 ` Sebastian Moeller
2025-01-10 16:34 ` Dave Taht
2025-01-10 17:02 ` Sebastian Moeller
2025-01-10 17:07 ` Dave Taht
2025-01-10 17:17 ` Sebastian Moeller
2025-01-10 17:43 ` Jonathan Morton
2025-01-10 19:43 ` Dave Taht
2025-01-10 20:34 ` Sebastian Moeller
2025-01-22 19:35 ` Dave Taht
2025-01-22 21:18 ` Sebastian Moeller
2025-01-10 19:06 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250110155531.300303-1-toke@redhat.com \
--to=toke@redhat.com \
--cc=cake@lists.bufferbloat.net \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=toke@toke.dk \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox