From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: David Ahern <dsahern@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: cake@lists.bufferbloat.net, netdev@vger.kernel.org,
"Jonas Köppeler" <j.koeppeler@tu-berlin.de>
Subject: [Cake] [PATCH iproute2-next] tc: cake: add cake_mq support
Date: Mon, 24 Nov 2025 16:03:50 +0100 [thread overview]
Message-ID: <20251124150350.492522-1-toke@redhat.com> (raw)
In-Reply-To: <20251124-mq-cake-sub-qdisc-v1-0-a2ff1dab488f@redhat.com>
From: Jonas Köppeler <j.koeppeler@tu-berlin.de>
This adds support for the cake_mq variant of sch_cake to tc.
Signed-off-by: Jonas Köppeler <j.koeppeler@tu-berlin.de>
---
include/uapi/linux/pkt_sched.h | 1 +
tc/q_cake.c | 13 ++++++++++++-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h
index 15d1a37ac6d8..fb07a8898225 100644
--- a/include/uapi/linux/pkt_sched.h
+++ b/include/uapi/linux/pkt_sched.h
@@ -1036,6 +1036,7 @@ enum {
TCA_CAKE_STATS_DROP_NEXT_US,
TCA_CAKE_STATS_P_DROP,
TCA_CAKE_STATS_BLUE_TIMER_US,
+ TCA_CAKE_STATS_ACTIVE_QUEUES,
__TCA_CAKE_STATS_MAX
};
#define TCA_CAKE_STATS_MAX (__TCA_CAKE_STATS_MAX - 1)
diff --git a/tc/q_cake.c b/tc/q_cake.c
index e2b8de55e5a2..1c143e766888 100644
--- a/tc/q_cake.c
+++ b/tc/q_cake.c
@@ -525,7 +525,6 @@ static int cake_print_opt(const struct qdisc_util *qu, FILE *f, struct rtattr *o
RTA_PAYLOAD(tb[TCA_CAKE_FWMARK]) >= sizeof(__u32)) {
fwmark = rta_getattr_u32(tb[TCA_CAKE_FWMARK]);
}
-
if (wash)
print_string(PRINT_FP, NULL, "wash ", NULL);
else
@@ -667,6 +666,11 @@ static int cake_print_xstats(const struct qdisc_util *qu, FILE *f,
" /%8u\n", GET_STAT_U32(MAX_ADJLEN));
}
+ if (st[TCA_CAKE_STATS_ACTIVE_QUEUES])
+ print_uint(PRINT_ANY, "active_queues",
+ " active queues: %25u\n",
+ GET_STAT_U32(ACTIVE_QUEUES));
+
if (st[TCA_CAKE_STATS_AVG_NETOFF])
print_uint(PRINT_ANY, "avg_hdr_offset",
" average network hdr offset: %12u\n\n",
@@ -827,3 +831,10 @@ struct qdisc_util cake_qdisc_util = {
.print_qopt = cake_print_opt,
.print_xstats = cake_print_xstats,
};
+
+struct qdisc_util cake_mq_qdisc_util = {
+ .id = "cake_mq",
+ .parse_qopt = cake_parse_opt,
+ .print_qopt = cake_print_opt,
+ .print_xstats = cake_print_xstats,
+};
--
2.51.2
next prev parent reply other threads:[~2025-11-24 15:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 14:59 [Cake] [PATCH net-next 0/4] Multi-queue aware sch_cake Toke Høiland-Jørgensen
2025-11-24 14:59 ` [Cake] [PATCH net-next 1/4] net/sched: sch_cake: Factor out config variables into separate struct Toke Høiland-Jørgensen
2025-11-24 14:59 ` [Cake] [PATCH net-next 2/4] net/sched: sch_cake: Add cake_mq qdisc for using cake on mq devices Toke Høiland-Jørgensen
2025-11-24 14:59 ` [Cake] [PATCH net-next 3/4] net/sched: sch_cake: Share config across cake_mq sub-qdiscs Toke Høiland-Jørgensen
2025-11-24 14:59 ` [Cake] [PATCH net-next 4/4] net/sched: sch_cake: share shaper state across sub-instances of cake_mq Toke Høiland-Jørgensen
2025-11-24 15:03 ` Toke Høiland-Jørgensen [this message]
2025-11-25 0:00 ` [Cake] Re: [PATCH iproute2-next] tc: cake: add cake_mq support David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251124150350.492522-1-toke@redhat.com \
--to=toke@redhat.com \
--cc=cake@lists.bufferbloat.net \
--cc=dsahern@gmail.com \
--cc=j.koeppeler@tu-berlin.de \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox