From: Jakub Kicinski <kuba@kernel.org>
To: Xiang Mei <xmei5@asu.edu>
Cc: security@kernel.org, netdev@vger.kernel.org, toke@toke.dk,
xiyou.wangcong@gmail.com, cake@lists.bufferbloat.net,
bestswngs@gmail.com
Subject: [Cake] Re: [PATCH net v7 1/2] net/sched: sch_cake: Fix incorrect qlen reduction in cake_drop
Date: Thu, 27 Nov 2025 15:36:44 -0800 [thread overview]
Message-ID: <20251127153644.55ef4796@kernel.org> (raw)
In-Reply-To: <20251126194513.3984722-1-xmei5@asu.edu>
On Wed, 26 Nov 2025 12:45:12 -0700 Xiang Mei wrote:
> In cake_drop(), qdisc_tree_reduce_backlog() is used to update the qlen
> and backlog of the qdisc hierarchy. Its caller, cake_enqueue(), assumes
> that the parent qdisc will enqueue the current packet. However, this
> assumption breaks when cake_enqueue() returns NET_XMIT_CN: the parent
> qdisc stops enqueuing current packet, leaving the tree qlen/backlog
> accounting inconsistent. This mismatch can lead to a NULL dereference
> (e.g., when the parent Qdisc is qfq_qdisc).
This series does not apply, please rebase on netdev/net/main.
--
pw-bot: cr
next prev parent reply other threads:[~2025-11-27 23:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 19:45 [Cake] " Xiang Mei
2025-11-26 19:45 ` [Cake] [PATCH net v7 2/2] selftests/tc-testing: Test CAKE scheduler when enqueue drops packets Xiang Mei
2025-11-27 9:14 ` [Cake] " Toke Høiland-Jørgensen
2025-11-27 18:22 ` Cong Wang
2025-11-27 9:14 ` [Cake] Re: [PATCH net v7 1/2] net/sched: sch_cake: Fix incorrect qlen reduction in cake_drop Toke Høiland-Jørgensen
2025-11-27 18:21 ` Cong Wang
2025-11-27 23:36 ` Jakub Kicinski [this message]
2025-11-28 0:16 ` Xiang Mei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251127153644.55ef4796@kernel.org \
--to=kuba@kernel.org \
--cc=bestswngs@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
--cc=toke@toke.dk \
--cc=xiyou.wangcong@gmail.com \
--cc=xmei5@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox