From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; spf=pass smtp.mailfrom=; dkim=pass header.d=kernel.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) by mail.toke.dk (Postfix) with ESMTPS id 44BA311E8C24 for ; Wed, 10 Jun 2026 02:45:48 +0200 (CEST) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id EA97044447; Wed, 10 Jun 2026 00:45:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6522C1F00893; Wed, 10 Jun 2026 00:45:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781052345; bh=bUj8Msp56Mm2mMjdrx9sk1nhQGk4EduoLIVQnB4R67o=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=iZ5kDwhzWLXlzr0YYDj4Psv1ry86ecP8/TiXPvdqkxoo2hFAYMTsZ6RmgxhZ1zNam PXZYMDW7aYOW99F3N6JX1Fq8F8QaaHKYC6rSWkJ42hofxCIXCalFL8d58u0Fm/VO3j mAGMO8uz6X1Q4GTgBHzfzq3UeN/JWrzKEvvcaA+Xka0zUZ3v/kUhvUCJao9HP6vurn IvWRVtdEqwI/Bgzou/Tn3lV8k194dIbYOvJtq50DDn6B23s6l62/rwGAuK9Czo7PPY 2T8ZV3BUOqLK+ZxpkYdjo+DkTnK4poRWwQkSk1ht0oGEol/reh/dFbyZ9HnWEmJSTl djS1FpCXZJiQg== Date: Tue, 9 Jun 2026 17:45:44 -0700 From: Jakub Kicinski To: Samuel Moelius Cc: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= , Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , cake@lists.bufferbloat.net (moderated list:CAKE QDISC), netdev@vger.kernel.org (open list:TC subsystem), linux-kernel@vger.kernel.org (open list) Message-ID: <20260609174544.114b82e0@kernel.org> In-Reply-To: <20260609232935.1602659.8545fdb04fbe.cake-overhead-underflow@trailofbits.com> References: <20260609232935.1602659.8545fdb04fbe.cake-overhead-underflow@trailofbits.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: A2XZYRBSE5JZ46SRCEJOEO7J3C3YXV47 X-Message-ID-Hash: A2XZYRBSE5JZ46SRCEJOEO7J3C3YXV47 X-MailFrom: kuba@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net v2] net/sched: cake: reject overhead values that underflow length List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 9 Jun 2026 23:29:36 +0000 Samuel Moelius wrote: > CAKE accepts overhead values that can make adjusted packet length > arithmetic underflow. A negative effective length can wrap through > unsigned arithmetic and become a large value. Sorry, why are you posting more patches? You were told to stop yesterday. And you received an email which said: Here are a few ground rules which are frequently broken by newcomers: - You must wait at least 24 hours before posting a new version to give reviewers time to respond. This is a hard rule, no matter what your reason to repost is. - Each new version of your series should be a fresh / separate thread Add a https://lore.kernel.org/.. link to the previous version to the cover letter or changelog, instead of threading the submissions. - Until you gain experience submit one of two patches at a time, do not send multiple changes at once until some of your changes were accepted. This avoids reviewers having to provide the same feedback on multiple patches. - Avoid changing the subject of the changes or cover letter unless necessary, it breaks our patch tracking. - If you're submitting changes for issues discovered using automated tools - commit message should explain the discovery and testing process (for drivers explicitly mention that you don't have access to the device, it's not a blocker). You broke at least 2 of these already. If you keep ignoring direct maintainer feedback you will be banned.