From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; spf=pass smtp.mailfrom=; dkim=pass header.d=kernel.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by mail.toke.dk (Postfix) with ESMTPS id A4FD711E920F for ; Wed, 10 Jun 2026 03:46:15 +0200 (CEST) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id D1456602CC; Wed, 10 Jun 2026 01:46:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AE461F00893; Wed, 10 Jun 2026 01:46:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781055973; bh=/sCY+d1gfCCjoCvIHTPWq3695luc6bFQV6ow0MGS6/k=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=o2WvagbGbZyWKnaNMm1ZnekisTI6BWbnNcqLzjoZ57uhehENBawYv1jrD7dMrfdLQ /tIJoaa+yiqC/TTvRIIiHXsUxTLZ6aHNEbMgmOTEvXo62liURvP4n1Ns3AE5ch8I4v aww++v5ibWsFQ/jj6ZjkNWz2XIwdj7jcfRZT+Wl5skHZjK7Np99zrF98M2eHxF1Q36 Z8qk73yibgaSigS65/XBzuylMfxlAyhq/C7l9VyVHFfc7kgcALRnLUYbQDW90/qvfl SzL6t7F3FkVv+FzwEoVAbBi7WB256qbRvdxH9+OQC0EO0qsjmuRrH6OkcCMER3b5zN tTOXH1ju5kdXg== Date: Tue, 9 Jun 2026 18:46:12 -0700 From: Jakub Kicinski To: Samuel Moelius Cc: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= , Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , "moderated list:CAKE QDISC" , "open list:TC subsystem" , open list Message-ID: <20260609184612.254a8000@kernel.org> In-Reply-To: References: <20260609232935.1602659.8545fdb04fbe.cake-overhead-underflow@trailofbits.com> <20260609174544.114b82e0@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-MailFrom: kuba@kernel.org X-Mailman-Rule-Hits: implicit-dest X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header Message-ID-Hash: ZKFTQIS23PALW4BG7EWCWHZUTONXAOHL X-Message-ID-Hash: ZKFTQIS23PALW4BG7EWCWHZUTONXAOHL X-Mailman-Approved-At: Wed, 10 Jun 2026 09:43:20 +0200 X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net v2] net/sched: cake: reject overhead values that underflow length List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 9 Jun 2026 20:55:35 -0400 Samuel Moelius wrote: > On Tue, Jun 9, 2026 at 8:45=E2=80=AFPM Jakub Kicinski w= rote: > > > > On Tue, 9 Jun 2026 23:29:36 +0000 Samuel Moelius wrote: =20 > > > CAKE accepts overhead values that can make adjusted packet length > > > arithmetic underflow. A negative effective length can wrap through > > > unsigned arithmetic and become a large value. =20 > > > > Sorry, why are you posting more patches? You were told to stop > > yesterday. And you received an email which said: > > > > Here are a few ground rules which are frequently broken by newcomers: > > > > - You must wait at least 24 hours before posting a new version to give > > reviewers time to respond. This is a hard rule, no matter what your > > reason to repost is. > > > > - Each new version of your series should be a fresh / separate thread > > Add a https://lore.kernel.org/.. link to the previous version to > > the cover letter or changelog, instead of threading the submissions. > > > > - Until you gain experience submit one of two patches at a time, > > do not send multiple changes at once until some of your changes > > were accepted. This avoids reviewers having to provide the same > > feedback on multiple patches. > > > > - Avoid changing the subject of the changes or cover letter unless > > necessary, it breaks our patch tracking. > > > > - If you're submitting changes for issues discovered using automated > > tools - commit message should explain the discovery and testing > > process (for drivers explicitly mention that you don't have access > > to the device, it's not a blocker). > > > > > > You broke at least 2 of these already. > > > > If you keep ignoring direct maintainer feedback you will be banned. =20 >=20 > I'm sorry for my misunderstanding. When should I resume submitting patche= s? Please wait until your outstanding submissions get reviewed, here is the patch review queue for netdev filtered down to your email: https://patchwork.kernel.org/project/netdevbpf/list/?submitter=3D222403 Once that's empty you can resume but again please try to go slow. 4 patches under review at a time, start from the most impactful ones. After you get >20 patches accepted (in networking specifically!) you=20 can open up the faucet a bit and go to 10 outstanding patches.