From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; spf=pass smtp.mailfrom=; dkim=pass header.d=kernel.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) by mail.toke.dk (Postfix) with ESMTPS id 62A1912A3E9A for ; Tue, 30 Jun 2026 00:42:31 +0200 (CEST) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 08128439BB; Mon, 29 Jun 2026 22:42:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 735301F000E9; Mon, 29 Jun 2026 22:42:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782772948; bh=dfGsgo+yOeIxzkSlnKWKokDKNnAd9uFqZ03mLJMQ/38=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=NrAiodgObb2yFqGGJQri6AIaCve5EmL2LVTm6FpN01BrRMSNXahENgpFLJAahKPOi ExapQOm/WvJl1AO2YcwcAG2x8sg3jmsvc9e48/n9JN5sIr8koTWYFEL26+vyr3GanM 9mC2jOadOH1TrlWpeDkNti3BwaWvfSVKEKykoiUU53Pf/uqEdEwcXiMkzssDjuPyEq fpF8U5r4y3GTBMZNi/hjcFvH319MhdwJ6q7Py5ShfPZnnjuyFtC6a/lr2UUJYcdKVj Ge43D38j4hwNblZ0DZ9nzuUebhZLUOsDpAgk+OZpPlMszbdFPLX9O61Kbyb1qaJNPR gTg6gMY8i77HQ== Date: Mon, 29 Jun 2026 15:42:27 -0700 From: Jakub Kicinski To: Samuel Moelius Cc: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= , Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , "moderated list:CAKE QDISC" , "open list:TC subsystem" , open list Message-ID: <20260629154227.741f2051@kernel.org> In-Reply-To: References: <20260609232935.1602659.8545fdb04fbe.cake-overhead-underflow@trailofbits.com> <20260613142626.1b2183eb@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-MailFrom: kuba@kernel.org X-Mailman-Rule-Hits: implicit-dest X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header Message-ID-Hash: 7HKTO4FAV3VUMO5RQAEZ34BDTIY6ENAN X-Message-ID-Hash: 7HKTO4FAV3VUMO5RQAEZ34BDTIY6ENAN X-Mailman-Approved-At: Tue, 30 Jun 2026 11:43:23 +0200 X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net v2] net/sched: cake: reject overhead values that underflow length List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 29 Jun 2026 14:44:28 -0400 Samuel Moelius wrote: > On Mon, Jun 29, 2026 at 1:24=E2=80=AFPM Samuel Moelius > wrote: > > > > On Sat, Jun 13, 2026 at 5:26=E2=80=AFPM Jakub Kicinski wrote: =20 > > > > > > On Tue, 9 Jun 2026 23:29:36 +0000 Samuel Moelius wrote: =20 > [...] =20 > > > > > > Both Sashiko's complain - these values are neither safe nor sufficien= t. > > > > > > How was the -64 chosen? It looks suspiciously close the min ethernet > > > frame length. =20 > > > > That's how it was chosen. But as you've shown, it was not a good choice. > > > > I would like to submit a revised patch that does the check on the > > datapath, as you suggested. Should I send that patch? Or would you > > prefer to wait for a response from Toke? =20 >=20 > Apologies. I just noticed Toke did reply. Should I send a patch > consistent with what he suggested? Yes please