From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=A6skGpwX; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by mail.toke.dk (Postfix) with ESMTPS id 8D0E714B22A6 for ; Sun, 16 Aug 2026 03:21:21 +0200 (CEST) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4954d29264cso11072585e9.2 for ; Sat, 15 Aug 2026 18:21:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786843279; x=1787448079; darn=lists.bufferbloat.net; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ZxQftwL2PECJ4SpESVyGEcp2FdWssPfyBN4bxwXPtrQ=; b=A6skGpwXMCzuACIBzwTFZ8rAIepFSRoW2VQrmySge0UYVTl6KqV0/Uq+orpiXICU9w rZ/6g+NBRawmEPmQS25Clfn79fLZtH0QeJgOpP/1Pj2McbBp2sluRhRnGCYOq+Rlv9Y/ kQPmzVCZK/yyOhwdvMjk+z2n8EYJH1aB19HQu7ngqvd9t/KX5LpSwTvmDgNXFIRxoe3q NAAaWwyEBmIiCJM+klXXluhUXUPCFUaDPVjO3LjxRuXpa9m9p/LGvloTqeatg2Qn8eBO aOPrlIBq0wsIycdoirX5orr8+mLJh74HxK3VK8965P/ZkV5fudTbMDCZKGRjJKwYUu3L j4nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786843279; x=1787448079; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZxQftwL2PECJ4SpESVyGEcp2FdWssPfyBN4bxwXPtrQ=; b=MTHluQZAgANsPbH7jXcTIiTUEKkhgkoDi/LGvo5vcRc1KiADt/hN/kEHnYu+U7RvT6 /FdkSKuPcwkLnHyOKcB/P3ERDkvHg0th7p903yK4vJRqRnbhUX82mi6odGREqwGIBaYm C7yHRBCXOwWoVrytVu5daOtEpbQzw9slShGLSBm+YtS1ZZdkHrFavHjPgyP6RC85z9B/ IA16i25fp3T0o1Yp3JhAcm3YT/CP38aPkjaS4GUbLYKkHqzLKDDTsi57c/ZsavrXL3X7 K4PJNYoLKdc0nOkqwXt/3+kFhTXB0K1yRMBoxv+vE4Z2HnwWIPr5jOOZ8arJNYG1Uv/o EHXQ== X-Forwarded-Encrypted: i=1; AHgh+RqAhToFV99P/x7OVGCKvm0avoHAA160PopZ20u/2EmOm6tMCQZjumwMeOSEiA6sagrOJKl+@lists.bufferbloat.net X-Gm-Message-State: AOJu0YzGtPS3blMCPbhh0N1mxkN3oE+OS/8O+7BjN0tckhfPKF6HQXZe yaSt3CmDU1cZZwQGz+cvjTA0U8Dwy/E3tZjj0StTSYq9PG8HE3Ir1sXO X-Gm-Gg: AR+sD12/aaOOKwEuqA2atufA6D7jai0FKimgBhfhYVQq001dXhorI4+cGeKiUCxEw/X zu6GqnIDPMMlwENi/+2AlIWeFOc5xBQuRfWngEZ8F2ROD1tAYJxjuB31Nk0TO9xwxg/uwtva82D BN2s9PzMfn2qPMj1PhFKTPiyhRF7kYQzMqruitJ8hI1dKIEwHI5ymsXhcxqrCofsPSGgU/Mrbq4 73DVL/JdVqI8SXTwQxhxjE1MKfDbD5GMBB2z7Q76qHHelS2bkCG7YUq4iyn5QyBhnXDR49wFYva 4liqFONHzGRhwAsXOptO6Ggfb/IpdUmku4T6OroyaHHBu2MaeZbzBsmQ73CE0G9redcaksz60fE HCmJUMVp3bRZ0SZ/MLJxv7VPbdlj3rfg0sj+1FlNLomMnMy+sQyCuNWKoK9Ees/qPcI0cUNTrAx xXQ/CwvnPtntuoWt8XNuyt+cbVFC9nZPTnLC2XO4osAE7jKzNsy3hNJGGh4FZAGKm/X7mlHgy+ X-Received: by 2002:a05:600c:4e14:b0:499:7e2b:8e5 with SMTP id 5b1f17b1804b1-4998793ffe7mr247502565e9.5.1786843279382; Sat, 15 Aug 2026 18:21:19 -0700 (PDT) Received: from unicorn.lan.internal ([2a0d:3341:b894:4600:78e4:e92e:b052:d281]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499961767f5sm923525e9.9.2026.08.15.18.21.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Aug 2026 18:21:18 -0700 (PDT) From: ooonea To: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= Cc: Jamal Hadi Salim , Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , cake@lists.bufferbloat.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 16 Aug 2026 03:21:09 +0200 Message-ID: <20260816012109.2865223-1-ooonea@gmail.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MailFrom: ooonea@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: 354ZXA5PWZUMHRWO6KVR7NS2PED4QTWR X-Message-ID-Hash: 354ZXA5PWZUMHRWO6KVR7NS2PED4QTWR X-Mailman-Approved-At: Sun, 16 Aug 2026 16:04:34 +0200 X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] [PATCH net] net/sched: sch_cake: fix autorate reconfiguration throttling List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: CAKE's autorate-ingress path intends to limit shaper reconfiguration to once per 250 ms, but last_reconfig_time is only checked and never updated. Since the field stays zero, every qualifying capacity-estimate window can call cake_reconfigure(), causing avoidable rate churn and scheduler work under bursty traffic. Store the current timestamp when autorate actually reconfigures the qdisc so the guard enforces the intended interval. Fixes: 7298de9cd725 ("sch_cake: Add ingress mode") Assisted-by: Codex:gpt-5.5 Signed-off-by: ooonea --- net/sched/sch_cake.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c index f25f60978..dc9326702 100644 --- a/net/sched/sch_cake.c +++ b/net/sched/sch_cake.c @@ -1907,6 +1907,7 @@ static s32 cake_enqueue(struct sk_buff *skb, struct Qdisc *sch, ktime_add_ms(q->last_reconfig_time, 250))) { q->config->rate_bps = (q->avg_peak_bandwidth * 15) >> 4; + q->last_reconfig_time = now; cake_reconfigure(sch); } } base-commit: 24ef02f934eeb48830cff6b739abc3c62b1d107b -- 2.54.0